Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes MicahZoltu as EIP editor. #5418

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Conversation

MicahZoltu
Copy link
Contributor

Context: We now have other editors who are relatively active so the response time for authors isn't as bad as it used to be (a week vs a year). It also sounds like the process for consensus changes will be moving over to the executable specs repository in the near future and since that is the piece I care most about, I am less concerned now than I used to be about the EIP process remaining credibly neutral.

I also will be unsubscribing from this repository, so someone should probably take up the the task of making sure stuff doesn't get lost in the cracks.

Note: I also reordered the Emeritus editors list to be alphabetical rather than what appeared to be random order.

Context: We now have other editors who are relatively active so the response time for authors isn't as bad as it used to be (a week vs a year).  It also sounds like the process for consensus changes will be moving over to the executable specs repository in the near future and since that is the piece I care most about, I am less concerned now than I used to be about the EIP process remaining credibly neutral.
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 5, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(pass) .github/workflows/auto-merge-bot.yml

classification
ambiguous
  • file .github/workflows/auto-merge-bot.yml is not a valid filename, but this error has been ignored due to editor approvals

(fail) eip-1.md

classification
updateEIP

ERC_EDITORS: "@lightclient,@axic,@SamWilsn,@Pandapip1"
NETWORKING_EDITORS: "@MicahZoltu,@lightclient,@axic,@SamWilsn"
NETWORKING_EDITORS: "@lightclient,@axic,@SamWilsn"
INTERFACE_EDITORS: "@lightclient,@axic,@SamWilsn,@Pandapip1"
META_EDITORS: "@lightclient,@axic,@gcolvin,@SamWilsn,@Pandapip1"
INFORMATIONAL_EDITORS: "@lightclient,@axic,@gcolvin,@SamWilsn,@Pandapip1"
Copy link
Member

@Pandapip1 Pandapip1 Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
INFORMATIONAL_EDITORS: "@lightclient,@axic,@gcolvin,@SamWilsn,@Pandapip1"
INFORMATIONAL_EDITORS: "@MicahZoltu,@lightclient,@axic,@gcolvin,@SamWilsn,@Pandapip1"

I feel like this particular change is very important. (/s obv)

Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all seriousness:

  • Someone else will need to be granted admin for this repository. There are enough changes that need to be manually merged, so having an active admin is essential. I propose @SamWilsn for this, since he will be the most active editor that's not me, but historically has made fewer controversial decisions than me.
  • You are currently the only active maintainer of the EIP-Bot repository. I feel pretty comfortable with the codebase there, and would be happy to help maintain it. But that means that at the very least I need write access (and preferably admin).

We could probably use #5414 to manage this.

@Pandapip1 Pandapip1 mentioned this pull request Aug 5, 2022
@MicahZoltu
Copy link
Contributor Author

I agree, that the repository will need someone with write permission who is active. I second your nomination of Sam, but I believe Sam explicitly said they don't want it in the past.

@SamWilsn
Copy link
Contributor

SamWilsn commented Aug 5, 2022

If you're leaving, @MicahZoltu, I'll accept write permissions.

@MicahZoltu
Copy link
Contributor Author

MicahZoltu commented Aug 5, 2022

I don't have permission to give you write permissions, @poojaranjan knows how to contact the right people for that though. Need Sam added to this team: https://github.com/orgs/ethereum/teams/eip-editors

@Pandapip1
Copy link
Member

If #5422 is implemented this will be a lot simpler.

@poojaranjan
Copy link
Contributor

I don't have permission to give you write permissions, @poojaranjan knows how to contact the right people for that though. Need Sam added to this team: https://github.com/orgs/ethereum/teams/eip-editors

I have requested the team to do the needful.

@MicahZoltu
Copy link
Contributor Author

MicahZoltu commented Aug 7, 2022

As my first, latest, and final act as Dictator of the EIP Editing process, I'm going to abuse my power and merge this without waiting for approval. 😈

Here is a picture of an innocent kitten to manipulate the emotional context that this event is stored with in your brain:
image

@MicahZoltu MicahZoltu marked this pull request as ready for review August 7, 2022 13:16
@MicahZoltu MicahZoltu closed this Aug 7, 2022
@MicahZoltu MicahZoltu reopened this Aug 7, 2022
@eth-bot eth-bot enabled auto-merge (squash) August 7, 2022 13:16
@MicahZoltu MicahZoltu disabled auto-merge August 7, 2022 13:20
@MicahZoltu MicahZoltu enabled auto-merge (squash) August 7, 2022 13:20
@MicahZoltu MicahZoltu disabled auto-merge August 7, 2022 13:21
@MicahZoltu MicahZoltu merged commit 4f56097 into ethereum:master Aug 7, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
Context: We now have other editors who are relatively active so the response time for authors isn't as bad as it used to be (a week vs a year).  It also sounds like the process for consensus changes will be moving over to the executable specs repository in the near future and since that is the piece I care most about, I am less concerned now than I used to be about the EIP process remaining credibly neutral.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants