-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes MicahZoltu as EIP editor. #5418
Conversation
Context: We now have other editors who are relatively active so the response time for authors isn't as bad as it used to be (a week vs a year). It also sounds like the process for consensus changes will be moving over to the executable specs repository in the near future and since that is the piece I care most about, I am less concerned now than I used to be about the EIP process remaining credibly neutral.
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (pass) .github/workflows/auto-merge-bot.yml
(fail) eip-1.md
|
ERC_EDITORS: "@lightclient,@axic,@SamWilsn,@Pandapip1" | ||
NETWORKING_EDITORS: "@MicahZoltu,@lightclient,@axic,@SamWilsn" | ||
NETWORKING_EDITORS: "@lightclient,@axic,@SamWilsn" | ||
INTERFACE_EDITORS: "@lightclient,@axic,@SamWilsn,@Pandapip1" | ||
META_EDITORS: "@lightclient,@axic,@gcolvin,@SamWilsn,@Pandapip1" | ||
INFORMATIONAL_EDITORS: "@lightclient,@axic,@gcolvin,@SamWilsn,@Pandapip1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
INFORMATIONAL_EDITORS: "@lightclient,@axic,@gcolvin,@SamWilsn,@Pandapip1" | |
INFORMATIONAL_EDITORS: "@MicahZoltu,@lightclient,@axic,@gcolvin,@SamWilsn,@Pandapip1" |
I feel like this particular change is very important. (/s obv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all seriousness:
- Someone else will need to be granted admin for this repository. There are enough changes that need to be manually merged, so having an active admin is essential. I propose @SamWilsn for this, since he will be the most active editor that's not me, but historically has made fewer controversial decisions than me.
- You are currently the only active maintainer of the EIP-Bot repository. I feel pretty comfortable with the codebase there, and would be happy to help maintain it. But that means that at the very least I need write access (and preferably admin).
We could probably use #5414 to manage this.
I agree, that the repository will need someone with write permission who is active. I second your nomination of Sam, but I believe Sam explicitly said they don't want it in the past. |
If you're leaving, @MicahZoltu, I'll accept write permissions. |
I don't have permission to give you write permissions, @poojaranjan knows how to contact the right people for that though. Need Sam added to this team: https://github.com/orgs/ethereum/teams/eip-editors |
If #5422 is implemented this will be a lot simpler. |
I have requested the team to do the needful. |
Context: We now have other editors who are relatively active so the response time for authors isn't as bad as it used to be (a week vs a year). It also sounds like the process for consensus changes will be moving over to the executable specs repository in the near future and since that is the piece I care most about, I am less concerned now than I used to be about the EIP process remaining credibly neutral.
Context: We now have other editors who are relatively active so the response time for authors isn't as bad as it used to be (a week vs a year). It also sounds like the process for consensus changes will be moving over to the executable specs repository in the near future and since that is the piece I care most about, I am less concerned now than I used to be about the EIP process remaining credibly neutral.
I also will be unsubscribing from this repository, so someone should probably take up the the task of making sure stuff doesn't get lost in the cracks.
Note: I also reordered the Emeritus editors list to be alphabetical rather than what appeared to be random order.