Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP Bot #5372

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Update EIP Bot #5372

merged 1 commit into from
Jul 30, 2022

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Jul 29, 2022

The current EIP Bot version is out of date. This PR bumps it to the most recent version.

Blocker: ethereum/EIP-Bot#105

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 29, 2022

All tests passed; auto-merging...

(pass) .github/workflows/auto-merge-bot.yml

classification
ambiguous
  • file .github/workflows/auto-merge-bot.yml is not a valid filename, but this error has been ignored due to editor approvals

@MicahZoltu MicahZoltu marked this pull request as ready for review July 30, 2022 09:01
@MicahZoltu MicahZoltu closed this Jul 30, 2022
@MicahZoltu MicahZoltu reopened this Jul 30, 2022
@eth-bot eth-bot enabled auto-merge (squash) July 30, 2022 09:03
@eth-bot eth-bot merged commit 81e7394 into ethereum:master Jul 30, 2022
@Pandapip1 Pandapip1 deleted the patch-2 branch July 30, 2022 23:08
@Pandapip1
Copy link
Member Author

Uh, this wasn't ready to merge. It wasn't even the latest version as of when this was merged 😆

@MicahZoltu
Copy link
Contributor

Ah, sorry. Once we get multiple reviewers required setup we can go back to using DRAFT as a meaningful thing. FWIW, I probably wouldn't have approved it if you set it to the latest. I approved because when I reviewed the changeset between the two versions it was all completely innocuous.

In the future, I'll leave it to the author to remove the DRAFT tag, rather than doing that bit myself. Sorry!

nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants