Finalize ERC-1271 #4717
Merged
Finalize ERC-1271 #4717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests passed; auto-merging...(pass) eip-1271.md
|
MicahZoltu
reviewed
Jan 25, 2022
There was a problem hiding this comment.
Simple Summary has been deprecated in favor of a description metadata field. In this case, you should also shorten it down to about a sentence, consider something like this:
description: A standard way for contracts to verify if a provided signature is valid when the account is a smart contract.
EIP links should be relative, change
[EIP-712](https://eips.ethereum.org/EIPS/eip-712)
to
[EIP-712](./eip-712.md)
PhABC
added a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
|
@MicahZoltu thanks! Updated both |
|
@PhABC could you please move "Security Considerations" below "Reference Implementation"? Other than that, I think it looks good on my end. |
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft, Review, or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
* Update eip-2315.md * Update eip-2315.md
* Update eip-4573.md * formatting eqn * Update eip-4573.md
* preview functions * swap preview
Well beyond the last-call deadline. Time to cement this and make it final.
|
@lightclient Done and rebased PR branch off master |
lightclient
approved these changes
Jan 25, 2022
|
Any reason why this isn’t getting merged? Looks like CI is stuck. |
auto-merge was automatically disabled
January 28, 2022 14:12
Pull request was closed
PowerStream3604
pushed a commit
to PowerStream3604/EIPs
that referenced
this pull request
May 19, 2022
* Fix date * Automatically merged updates to draft EIP(s) 3416 (ethereum#3446) Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft, Review, or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing * Update eip-2315.md (ethereum#3760) * Update eip-2315.md * Update eip-2315.md * Update eip-4573.md (ethereum#4680) * Update eip-4573.md * formatting eqn * Update eip-4573.md * EIP-4626: Preview functions (ethereum#4705) * preview functions * swap preview * Finalize ERC-1271 Well beyond the last-call deadline. Time to cement this and make it final. Co-authored-by: hexzorro <[email protected]> Co-authored-by: Greg Colvin <[email protected]> Co-authored-by: Alberto Cuesta Cañada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well beyond the last-call deadline. Time to cement this and make it final.