Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time-Aware Base Fee Calculation #4396

Merged
merged 16 commits into from
Nov 1, 2021
Merged

Time-Aware Base Fee Calculation #4396

merged 16 commits into from
Nov 1, 2021

Conversation

adietrichs
Copy link
Member

@adietrichs adietrichs commented Oct 29, 2021 •
edited
Loading

This EIP proposes accounting for time between blocks in the base fee calculation to target a stable throughput by time, instead of by block. Aiming to minimize changes to the calculation, it only introduces a variable block gas target proportional to the block time. The EIP can, in principle, be applied to either a Proof-of-Work or a Proof-of-Stake chain, however the security implications for the Proof-of-Work case remain unexplored.

@eth-bot eth-bot enabled auto-merge (squash) October 29, 2021 03:59
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 29, 2021

EIP file name must be eip-###.md

@adietrichs adietrichs mentioned this pull request Oct 29, 2021
Closed
lightclient
lightclient requested changes Oct 29, 2021
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but overall well written :) thanks!

EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
SamWilsn
SamWilsn reviewed Oct 29, 2021
View reviewed changes
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
EIPS/eip-time_aware_basefee.md Outdated Show resolved Hide resolved
@adietrichs @SamWilsn @lightclient
Apply suggestions from code review
0843d40 
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: lightclient <[email protected]>
auto-merge was automatically disabled October 29, 2021 12:57

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) October 29, 2021 12:58
auto-merge was automatically disabled October 29, 2021 13:09

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) October 29, 2021 13:09
auto-merge was automatically disabled October 29, 2021 13:19

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) October 29, 2021 13:20
auto-merge was automatically disabled October 29, 2021 13:21

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) October 29, 2021 13:22
lightclient
lightclient reviewed Oct 29, 2021
View reviewed changes
EIPS/eip-4396.md Outdated Show resolved Hide resolved
@MicahZoltu MicahZoltu closed this Oct 30, 2021
auto-merge was automatically disabled October 30, 2021 08:47

Pull request was closed

@MicahZoltu MicahZoltu reopened this Oct 30, 2021
@eth-bot eth-bot enabled auto-merge (squash) October 30, 2021 08:47
alita-moore
alita-moore reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@alita-moore alita-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing bot

alita-moore
alita-moore reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@alita-moore alita-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing bot

@MicahZoltu MicahZoltu closed this Nov 1, 2021
auto-merge was automatically disabled November 1, 2021 13:39

Pull request was closed

@MicahZoltu MicahZoltu reopened this Nov 1, 2021
@eth-bot eth-bot enabled auto-merge (squash) November 1, 2021 13:39
@MicahZoltu
Copy link
Contributor

@alita-moore So close. This time it failed on the first one instead of the 4th. 😖 Merging manually since it has been discovered that I'm using the broken bot to censor people and I have to make a show of being benevolent.

@MicahZoltu MicahZoltu disabled auto-merge November 1, 2021 15:05
@MicahZoltu MicahZoltu merged commit d5e5dcd into ethereum:master Nov 1, 2021
@alita-moore
Copy link
Contributor

alita-moore commented Nov 1, 2021 •
edited
Loading

Oh I see this is an edge case @MicahZoltu. Shall I treat this the same as eip-1?

Also typical dictators 😆

@MicahZoltu
Copy link
Contributor

@alita-moore Why is this an edge case? What happened that caused this to not merge?

@alita-moore
Copy link
Contributor

@alita-moore Why is this an edge case? What happened that caused this to not merge?

Ah looks like I got my mentions mixed up. I was thinking about the bot not parsing eip-###.md

In this case it's most likely because of the fact non-eip are not supported (this touched assets folder). Do you recommend I prioritize this above all else?

@MicahZoltu
Copy link
Contributor

Ah, I thought you already added support for assets/eip-####.md. If that is still in the backlog then this failing makes sense. It would be nice if the error message was a bit more clear, maybe we should also get an issue into the backlog for that.

PhABC pushed a commit to PhABC/EIPs that referenced this pull request Jan 25, 2022
@adietrichs @SamWilsn
@lightclient @PhABC
Time-Aware Base Fee Calculation (ethereum#4396)
cf59226 
* create EIP from template

* rename EIP and fill header

* add skeleton content

* update specification

* fixed incorrect link

* updated specification to allign with EIP-1559

* added throughput graphs

* add graph files

* fill abstract and update motivation

* fill security considerations

* fill rationale

* Apply suggestions from code review

Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: lightclient <[email protected]>

* rename files using EIP number

* add eth-magicians link

* update header description

* Update EIPS/eip-4396.md

Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: lightclient <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn left review comments

@alita-moore alita-moore alita-moore left review comments

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adietrichs @eth-bot @MicahZoltu @alita-moore @lightclient @SamWilsn