Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix figure comment #3187

Merged
merged 1 commit into from
Jan 7, 2021
Merged

fix figure comment #3187

merged 1 commit into from
Jan 7, 2021

Conversation

gballet
Copy link
Member

@gballet gballet commented Jan 5, 2021

Fix an error in the tree deletion diagram

DGKSK8LIFE
DGKSK8LIFE approved these changes Jan 5, 2021
View reviewed changes
Copy link

@DGKSK8LIFE DGKSK8LIFE left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PR commit includes better articulation as well as nicer svg styles. ( as well as the aforementioned error fix)

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • File assets/eip-3102/sibling.svg is not an EIP

@MicahZoltu MicahZoltu merged commit 1cee548 into ethereum:master Jan 7, 2021
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
@gballet @Arachnid
fix figure comment (ethereum#3187)
d2c994c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DGKSK8LIFE DGKSK8LIFE DGKSK8LIFE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gballet @eip-automerger @DGKSK8LIFE @MicahZoltu