feat: Extended ERC-3156 #3180
Merged
feat: Extended ERC-3156 #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
Hi, I'm a bot! This change was automatically merged because: - It only modifies existing Draft or Last Call EIP(s) - The PR was approved or written by at least one author of each modified EIP - The build is passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon discussion with @moodysalem and others, and after developing ERC-3156 wrappers for existing flash lenders, it's apparent that ERC-3156 needs to be extended if it is to be adopted.
The extensions are limited to:
address tokenparameter inflashLoanandonFlashLoanto specify the tokens that are object of the loan.flashSupplyfunction to reveal the maximum loan available for alenderandtoken.flashFeefunction to reveal the fee charged for alender,tokenand loanamount.Please have a look at the ERC20 Flash repository if curious. I think that it is very telling how the same contract was used for all the tests, and how the test files were almost identical for executing flash loans with dYdX, Aave, Uniswap and Yield.