Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3155: Remove superfluous test cases #3159

Merged
merged 5 commits into from
Dec 9, 2020

Conversation

MariusVanDerWijden
Copy link
Member

Removes a superfluous test case and adds a more meaningful test case.
Removes unnecessary logic concerning the inputs.

cc @shemnon

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a few nitpicks

EIPS/eip-3155.md Outdated Show resolved Hide resolved
EIPS/eip-3155.md Outdated Show resolved Hide resolved
@eip-automerger eip-automerger merged commit fa6bfb2 into ethereum:master Dec 9, 2020
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants