-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-152: Blake2b F
precompile
#2129
Commits on Jun 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 89a8794 - Browse repository at this point
Copy the full SHA 89a8794View commit details -
Make the draft EIP consistent with the template
Also added myself as an author
Configuration menu - View commit details
-
Copy full SHA for 843d377 - Browse repository at this point
Copy the full SHA 843d377View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bcce1d - Browse repository at this point
Copy the full SHA 3bcce1dView commit details -
Added notes about the in-progress implementation
Should have a working geth precompile and initial benchmarks shortly
Configuration menu - View commit details
-
Copy full SHA for c3f4c68 - Browse repository at this point
Copy the full SHA c3f4c68View commit details -
Specify EIP-2046 as a requirement
While 2046's cheaper precompile contract calls aren't a requirement for this EIP's implementation, shipping this precompile without EIP-2046 would make the F function expensive for some of the motivating usecases.
Configuration menu - View commit details
-
Copy full SHA for 92916e1 - Browse repository at this point
Copy the full SHA 92916e1View commit details
Commits on Jun 20, 2019
-
Don't use ABI encoding for precompile
Replace the existing ABI encoding interface to the BLAKE2b `F` precompile with a loosely pack struct that's `staticcall`-friendly. H/t to @pdyraga for putting together the interface!
Configuration menu - View commit details
-
Copy full SHA for 764ff73 - Browse repository at this point
Copy the full SHA 764ff73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15c3352 - Browse repository at this point
Copy the full SHA 15c3352View commit details -
Remove less relevant EIP rationale
Let's not relitigate precompiles, WASM, etc in thie EIP :)
Configuration menu - View commit details
-
Copy full SHA for 552e602 - Browse repository at this point
Copy the full SHA 552e602View commit details -
Use 0x09 as the precompile address
If a conflicting EIP is moving forward the EIP editor can assign a new address
Configuration menu - View commit details
-
Copy full SHA for 5a29338 - Browse repository at this point
Copy the full SHA 5a29338View commit details
Commits on Jun 21, 2019
-
Contributing docs suggest EIPs be named `eip-draft-with-a-title` until an editor has been assigned, but discussing this work off-platform without a number is a problem. Assigning 152 as the issue number where the `F` precompile was originally raised (ethereum#152)
Configuration menu - View commit details
-
Copy full SHA for 5d203c4 - Browse repository at this point
Copy the full SHA 5d203c4View commit details
Commits on Jun 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6e7c49a - Browse repository at this point
Copy the full SHA 6e7c49aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed06f26 - Browse repository at this point
Copy the full SHA ed06f26View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6dadde - Browse repository at this point
Copy the full SHA f6daddeView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb54861 - Browse repository at this point
Copy the full SHA eb54861View commit details
Commits on Jun 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 47ac208 - Browse repository at this point
Copy the full SHA 47ac208View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29423a1 - Browse repository at this point
Copy the full SHA 29423a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f9384f - Browse repository at this point
Copy the full SHA 2f9384fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7621447 - Browse repository at this point
Copy the full SHA 7621447View commit details
Commits on Jun 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 94ebe0c - Browse repository at this point
Copy the full SHA 94ebe0cView commit details
Commits on Jun 27, 2019
-
Updated the interface for F precompile
- F precompile accepts now `abi.encodePacked` parameters taking exactly 213 bytes. This is safer and does not require left-padding data - `rounds` parameter is now the first one as the gas cost depends only on this parameter
Configuration menu - View commit details
-
Copy full SHA for 787c2a0 - Browse repository at this point
Copy the full SHA 787c2a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c09e88 - Browse repository at this point
Copy the full SHA 9c09e88View commit details
Commits on Jun 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9d354f3 - Browse repository at this point
Copy the full SHA 9d354f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cd9f95 - Browse repository at this point
Copy the full SHA 7cd9f95View commit details -
Clarification: f parameter is true if it is nonzero
This rule is compatible with Solidity for boolean.
Configuration menu - View commit details
-
Copy full SHA for 7338048 - Browse repository at this point
Copy the full SHA 7338048View commit details
Commits on Jul 4, 2019
-
Avoid referring to abi.encodePacked
The specification should not be Solidity-specific. Instead of referring to abi.encodePacked we now just say "tightly encoded".
Configuration menu - View commit details
-
Copy full SHA for 534e4b3 - Browse repository at this point
Copy the full SHA 534e4b3View commit details -
"specified in the RFC" linked to the geth PR for F precompile instead of linking to the BLAKE2b RFC.
Configuration menu - View commit details
-
Copy full SHA for ea28226 - Browse repository at this point
Copy the full SHA ea28226View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e33d58 - Browse repository at this point
Copy the full SHA 2e33d58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 701280c - Browse repository at this point
Copy the full SHA 701280cView commit details
Commits on Aug 13, 2019
-
Updated information about endianness of F precompile inputs
BLAKE2b is consistently little-endian. abi.encodePacked encodes each of its arguments in big-endian order. We need to be clear which parameters should go as little-endian (h, m, t) and which parameters should go as big-endian (rounds, f).
Configuration menu - View commit details
-
Copy full SHA for 64830d1 - Browse repository at this point
Copy the full SHA 64830d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcf86f6 - Browse repository at this point
Copy the full SHA dcf86f6View commit details -
Initial test vectors for F precompile
Test cases covered: - input length too short - input length too long - malformed f flag encoding - correct input, test vector from BLAKE2b RFC, Appendix A
Configuration menu - View commit details
-
Copy full SHA for e30104c - Browse repository at this point
Copy the full SHA e30104cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65f1caa - Browse repository at this point
Copy the full SHA 65f1caaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a40bc66 - Browse repository at this point
Copy the full SHA a40bc66View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8d33ba - Browse repository at this point
Copy the full SHA b8d33baView commit details
Commits on Aug 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7e2f8a1 - Browse repository at this point
Copy the full SHA 7e2f8a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 817e12d - Browse repository at this point
Copy the full SHA 817e12dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2386c0e - Browse repository at this point
Copy the full SHA 2386c0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1255c52 - Browse repository at this point
Copy the full SHA 1255c52View commit details
Commits on Aug 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 272c45f - Browse repository at this point
Copy the full SHA 272c45fView commit details