-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-1231: Reduce CALL cost for precompiles #1231
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
--- | ||
eip: 1231 | ||
title: Reduce cost of CALLs to precompiles | ||
author: Matthew Di Ferrante (@mattdf) | ||
status: Draft | ||
type: Standards Track | ||
category: Core | ||
created: 2018-07-19 | ||
requires: 150, 158 | ||
--- | ||
|
||
## Short Description | ||
|
||
The Spurious Dragon hard fork increased the cost of CALLs to mitigate protocol DoS attacks that involved reads, but it failed to distinguish between CALLs to precompiles and CALLs to deployed contracts. This is an oversight that should be corrected. | ||
|
||
## Motivation | ||
|
||
There are useful precompiles such as a ECADD, SHA256, RIPEMD and the identity precompile (useful for memcpy) which have a gas cost that is far below or approximately equal to the cost of a CALL, which restricts their usefulness if they need to be called many times in a loop. This can cause a 2x to 10x increase in gas cost due to the CALL cost overhead, particularly with SHA256 and ECADD which often require tight loops for certain cryptographic protocols. | ||
|
||
In the Spurious Dragon hard fork, the cost of CALLs across the board was raised to 700 gas to mitigate DoS from state reads, without making a distinction between precompiles and deployed contracts. It does not make sense that precompiles should also suffer from the DoS mitigation penalty, since the precompiles are part of the core node code and hence never need to be fetched from disk. The CALL cost for precompiles should be reverted back to pre-EIP150 values, to 40 gas per call. | ||
|
||
## Specification | ||
|
||
Following is a table with the current gas cost and new gas cost: | ||
|
||
| Opcode name | Opcodes | Current Gas Cost | Updated Gas Cost | | ||
| ------------------------------ | --------- | ----------------------------- | ------------------- | | ||
| `CALL` (to precompiles) | `0xf1` | 700<sup>[1]</sup> | 40 | | ||
| `CALLCODE` (to precompiles) | `0xf2` | 700<sup>[1]</sup> | 40 | | ||
| `DELEGATECALL` (to precompiles)| `0xf3` | 700<sup>[1]</sup> | 40 | | ||
| `STATICCALL` (to precompiles) | `0xf4` | 700<sup>[1]</sup> | 40 | | ||
| `CALL` (to contracts) | `0xf1` | 700<sup>[1]</sup> | 700 (unchanged) | | ||
| `CALLCODE` (to contracts) | `0xf2` | 700<sup>[1]</sup> | 700 (unchanged) | | ||
| `DELEGATECALL` (to contracts) | `0xf3` | 700<sup>[1]</sup> | 700 (unchanged) | | ||
| `STATICCALL` (to contracts) | `0xf4` | 700<sup>[1]</sup> | 700 (unchanged) | | ||
|
||
|
||
[1]- Per EIP-150 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the table necessary, since it's the same for all types of call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be removed..