Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating EIP-1202 DRAFT #1209

Closed
wants to merge 8 commits into from
Closed

Creating EIP-1202 DRAFT #1209

wants to merge 8 commits into from

Conversation

xinbenlv
Copy link
Contributor

Please discuss this PR and EIP at #1202

@xinbenlv
Copy link
Contributor Author

Ready to check-in.

@xinbenlv
Copy link
Contributor Author

Dear editor team, how do I request the PR to be merged?

@xinbenlv xinbenlv changed the title Creating EIP-1202 WIP Creating EIP-1202 DRAFT Jul 11, 2018
@xinbenlv
Copy link
Contributor Author

Bump~

Copy link
Contributor Author

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request for approval

// TODO: provide example interface and implementation

## Specificiations
// TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please actually have a standard before you submit a PR to add a draft to the repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I created #1237 and please take look if that is what you refer to?

@Arachnid Arachnid closed this Jul 17, 2018
@xinbenlv xinbenlv mentioned this pull request Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants