Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

Require CC0 waiver #70

Closed
SamWilsn opened this issue Apr 20, 2022 · 9 comments
Closed

Require CC0 waiver #70

SamWilsn opened this issue Apr 20, 2022 · 9 comments

Comments

@SamWilsn
Copy link

Originally from #55

At minimum, it would be nice if the bot failed CI if an EIP does not contain the CC0 waiver.

A further step would be to either comment on the PR, or automatically apply the suggestion to the PR.

Personally I would prefer a comment on the PR, but we should probably discuss in this issue.

@JEAlfonsoP
Copy link
Contributor

I will work on it.

@Pandapip1
Copy link
Member

Pandapip1 commented May 1, 2022

Note/Blocker: ethereum/EIPs#5055

@JEAlfonsoP
Copy link
Contributor

So bot must failed if no CC0 waiver ? (Direct Question)

@MicahZoltu
Copy link
Contributor

Yes, if a new EIP doesn't have the exactly correct license section then the bot should hard fail. Even better, it would comment on the PR indicating what needs to be changed/fixed.

@JEAlfonsoP
Copy link
Contributor

Is it a possibility just before merge, to check if license is null, warn and update license = CC0 ?
Let me know if you agree with it.

@Pandapip1
Copy link
Member

Well, IIUC the user needs to agree to it (see metamask's CLA bot)

@MicahZoltu
Copy link
Contributor

MicahZoltu commented May 2, 2022

We don't need some special process for agreeing to the CC0, we just need to enforce that every EIP touched has the proper CC0 license lines. This would mean that any PR that edits an EIP would be checked to make sure the CC0 lines are present at the end of the document. If they aren't, the bot should fail the check and (bonus) comment on the PR letting the user know they need to fix it.

@MicahZoltu
Copy link
Contributor

This is handled by EIPW now.

@SamWilsn
Copy link
Author

This is handled by EIPW now.

It isn't, but I have an issue open for it: ethereum/eipw#27. It should be pretty easy to implement as an eipw lint.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants