-
Notifications
You must be signed in to change notification settings - Fork 37
Require CC0 waiver #70
Comments
I will work on it. |
Note/Blocker: ethereum/EIPs#5055 |
So bot must failed if no CC0 waiver ? (Direct Question) |
Yes, if a new EIP doesn't have the exactly correct license section then the bot should hard fail. Even better, it would comment on the PR indicating what needs to be changed/fixed. |
Is it a possibility just before merge, to check if license is null, warn and update license = CC0 ? |
Well, IIUC the user needs to agree to it (see metamask's CLA bot) |
We don't need some special process for agreeing to the CC0, we just need to enforce that every EIP touched has the proper CC0 license lines. This would mean that any PR that edits an EIP would be checked to make sure the CC0 lines are present at the end of the document. If they aren't, the bot should fail the check and (bonus) comment on the PR letting the user know they need to fix it. |
This is handled by EIPW now. |
It isn't, but I have an issue open for it: ethereum/eipw#27. It should be pretty easy to implement as an |
Originally from #55
At minimum, it would be nice if the bot failed CI if an EIP does not contain the CC0 waiver.
A further step would be to either comment on the PR, or automatically apply the suggestion to the PR.
Personally I would prefer a comment on the PR, but we should probably discuss in this issue.
The text was updated successfully, but these errors were encountered: