Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

Close some issues #104

Closed
Pandapip1 opened this issue Jul 24, 2022 · 7 comments
Closed

Close some issues #104

Pandapip1 opened this issue Jul 24, 2022 · 7 comments

Comments

@Pandapip1
Copy link
Member

Specifically, the linting issues.

Those are being handled by https://github.com/ethereum/eipw

@Pandapip1
Copy link
Member Author

Pandapip1 commented Jul 29, 2022

Issues to be closed:
#98
#96
#93
#74
#73
#72
#71
#70
#69
#68
PRs to be closed:
#89
#87

@Pandapip1
Copy link
Member Author

CC @MicahZoltu

@MicahZoltu
Copy link
Contributor

It is probably better to comment on each of the respective issues, rather than collating them here. It makes it harder to track/manage and discuss when there is a monolithic list like this.

Are you sure EIPW handles #93? I thought we still had a problem with that?

@MicahZoltu
Copy link
Contributor

Same question for #74 and #69, are we sure the bot handles these? For #69 I thought we were still actively debating what the behavior should be and the bot doesn't do anything about them at the moment?

@Pandapip1
Copy link
Member Author

Are you sure EIPW handles #93? I thought we still had a problem with that?

Same question for #74 and #69, are we sure the bot handles these?

There are open issues on the eipw repo. This place is no longer the right place to track this.

@MicahZoltu
Copy link
Contributor

I don't see a replication of #93 on EIPW issues list, do you happen to know which number it is?

I guess #74 is handled by the more general "no external links allowed" lint that we currently have.

I also don't see an issue duplicating #69 in the EIPW repository.

@Pandapip1
Copy link
Member Author

Issues made.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants