-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: several housekeeping changes #68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the numbers above are correct let's strip the caching out for now. |
geoknee
force-pushed
the
gk/cci-cache-fix
branch
from
January 30, 2024 16:35
d378de1
to
4bc3170
Compare
geoknee
commented
Jan 30, 2024
geoknee
changed the title
ci: attempt to fix go modules caching behaviour
ci: several housekeeping changes
Jan 30, 2024
mslipper
approved these changes
Jan 30, 2024
sebastianst
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for cleaning that up! Found one typo.
Would also be nice to add a short pointer to the CONTRIBUTING.md
guide for adding new chains.
protolambda
approved these changes
Jan 30, 2024
Co-authored-by: Sebastian Stammler <[email protected]>
geoknee
force-pushed
the
gk/cci-cache-fix
branch
from
January 31, 2024 15:05
088849c
to
713a2b8
Compare
zchn
approved these changes
Jan 31, 2024
zchn
requested review from
protolambda and
zchn
and removed request for
protolambda
January 31, 2024 15:46
zchn
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up changes from the new module structure introduced in #62:
go mod tidy
in each module doesn't generate any changesgo.work.sum
. AFAICT this file doesn't do anything for us in the way I anticipate this repo will be used, but it does get updated from time to time in a way that isn't well documented and could cause confusion.Context
go.sum
from the top level as a cache key.go.work
file proposal: ref/mod: mention whether go.work files should be checked into VCS golang/go#53502 . However, IMO it is worth it because it makes editors like VSCode understand the repo structure better so that all the usual editor features "just work".Tests
manual
Open Questions
I'm not 100% sure thatIt definitely won't. And I am fairly surego.work
will change when we update dependencies. Probably about 80% sure.go.work.sum
won't change be guaranteed to either.