Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: several housekeeping changes #68

Merged
merged 9 commits into from
Jan 31, 2024
Merged

ci: several housekeeping changes #68

merged 9 commits into from
Jan 31, 2024

Conversation

geoknee
Copy link
Collaborator

@geoknee geoknee commented Jan 29, 2024

Description
Follow up changes from the new module structure introduced in #62:

  • removes go module caching from CI (it was causing an error and even when fixed was not speeding up CI runs)
  • updates readme to explain existence of multiple modules in this repository
  • updates CI config to check the running go mod tidy in each module doesn't generate any changes
  • gitignores go.work.sum. AFAICT this file doesn't do anything for us in the way I anticipate this repo will be used, but it does get updated from time to time in a way that isn't well documented and could cause confusion.

Context

Tests

manual

Open Questions

  • I'm not 100% sure that go.work will change when we update dependencies. Probably about 80% sure. It definitely won't. And I am fairly sure go.work.sum won't change be guaranteed to either.
  • I'm not convinced we really need caching at this point. On circle, it took 16s to restore a cache, but downloading the dependencies only took 6s.

@mslipper
Copy link
Contributor

If the numbers above are correct let's strip the caching out for now.

.circleci/config.yml Outdated Show resolved Hide resolved
@geoknee geoknee changed the title ci: attempt to fix go modules caching behaviour ci: several housekeeping changes Jan 30, 2024
@geoknee geoknee marked this pull request as ready for review January 30, 2024 16:58
@geoknee geoknee requested a review from a team as a code owner January 30, 2024 16:58
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for cleaning that up! Found one typo.

Would also be nice to add a short pointer to the CONTRIBUTING.md guide for adding new chains.

README.md Outdated Show resolved Hide resolved
@zchn zchn requested review from protolambda and zchn and removed request for protolambda January 31, 2024 15:46
@zchn zchn merged commit 1682ef5 into main Jan 31, 2024
10 checks passed
@zchn zchn deleted the gk/cci-cache-fix branch January 31, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants