Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency on superchain-registry #9929

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Mar 20, 2024

Pulls in removal of the goerli superchain. To get tests passing, I had to change references to Goerli throughout the monorepo, either removing or replacing with sepolia.

Copy link
Contributor

coderabbitai bot commented Mar 20, 2024

Walkthrough

Walkthrough

The modifications across the op-node package focus on removing the Goerli testnet's configuration and references. This includes the deletion of the Goerli variable, along with related constants and logic within the code. Adjustments were also made to the chain ID configurations, particularly emphasizing the removal of Goerli testnet settings and the update of certain test assertions to align with these changes.

Changes

Files Change Summary
chaincfg/chains.go Removed the Goerli variable declaration and assignment, affecting the configuration setup.
rollup/superchain.go Eliminated Goerli-related constants and logic, including adjustments for pgnSepolia.
rollup/types_test.go Updated L1ChainID value in tests, adjusted expected output in assertions, removed a blank line.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.26%. Comparing base (a039f5a) to head (dd2aadf).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9929      +/-   ##
===========================================
- Coverage    28.25%   25.26%   -2.99%     
===========================================
  Files          165      102      -63     
  Lines         7295     3554    -3741     
  Branches      1335      576     -759     
===========================================
- Hits          2061      898    -1163     
+ Misses        5128     2625    -2503     
+ Partials       106       31      -75     
Flag Coverage Δ
cannon-go-tests 82.29% <ø> (ø)
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests 0.60% <ø> (ø)
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes

@geoknee geoknee marked this pull request as draft March 20, 2024 22:10
@geoknee geoknee marked this pull request as ready for review March 22, 2024 15:31
@geoknee geoknee requested a review from a team as a code owner March 22, 2024 15:31
@geoknee geoknee requested a review from sebastianst March 22, 2024 15:31
sebastianst
sebastianst previously approved these changes Mar 26, 2024
@sebastianst sebastianst dismissed their stale review March 26, 2024 14:07

found a few places I also wanna remove for consistency, requesting other review

@sebastianst sebastianst added this pull request to the merge queue Mar 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2024
@sebastianst sebastianst added this pull request to the merge queue Mar 26, 2024
Merged via the queue into develop with commit 5137f3b Mar 26, 2024
73 checks passed
@sebastianst sebastianst deleted the gk/update-registry branch March 26, 2024 20:04
0xfuturistic pushed a commit that referenced this pull request Apr 24, 2024
* go get github.com/ethereum-optimism/superchain-registry/superchain@52d3dbd1605dd43f419e838584abd0ec163d462b

* make mod-tidy

* remove goerli chaincfg

* op-program: replace references to goerli with sepolia

* op-node: remove references to goerli or replace with sepolia

* remove unused var

* go: update op-geth to latest v1.101308.4-rc.1

* op-node: remove Goerli references & config overrides

---------

Co-authored-by: Sebastian Stammler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants