feat(op-node): p2p rpc input validation

[felipe-op]

Description

This change hardness the input validation on authoritative P2P RPC methods for op-node.

Tests

Added new invalid input cases.

Additional context

Part of PMS: https://github.com/ethereum-optimism/devinfra-pod/issues/38

Metadata

• Fixes https://github.com/ethereum-optimism/client-pod/issues/666

[coderabbitai]

Walkthrough

Walkthrough

The recent updates focus on enhancing error handling and validation for peer-to-peer (P2P) networking functionalities. New error checks have been introduced in client functions concerning peer management tasks such as blocking, unblocking, protecting, and connecting. Additionally, a specific error, ErrInvalidRequest, has been added to signal invalid requests, alongside updates in parameter naming and validation to improve clarity and security in RPC operations.

Changes

Files	Change Summary
.../p2p/host_test.go	Introduced new error checks for P2P client functions related to peer management (blocking, unblocking, protecting, connecting).
.../p2p/rpc_server.go	- Added ErrInvalidRequest. - Updated parameter names from p to id in various functions. - Added validation and logging for invalid id parameters. - Functions affected: BlockPeer, UnblockPeer, BlockAddr, UnblockAddr, BlockSubnet, UnblockSubnet, ProtectPeer, UnprotectPeer, DisconnectPeer.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.60%. Comparing base (c9bdd91) to head (067e310).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #9897       +/-   ##
===========================================
- Coverage    28.53%   0.60%   -27.93%     
===========================================
  Files          164      91       -73     
  Lines         7211    2460     -4751     
  Branches      1321     572      -749     
===========================================
- Hits          2058      15     -2043     
+ Misses        5047    2445     -2602     
+ Partials       106       0      -106     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	?
common-ts-tests	?
contracts-bedrock-tests	0.60% <ø> (ø)
contracts-ts-tests	?
core-utils-tests	?
sdk-next-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 73 files with indirect coverage changes