-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-program: Avoid requesting L1 genesis block when starting from L2 genesis #9807
Conversation
WalkthroughWalkthroughThe recent update introduces a new method Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9807 +/- ##
===========================================
- Coverage 28.53% 0.60% -27.93%
===========================================
Files 164 91 -73
Lines 7212 2461 -4751
Branches 1322 573 -749
===========================================
- Hits 2058 15 -2043
+ Misses 5048 2446 -2602
+ Partials 106 0 -106
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Avoids requesting the L1 genesis block to populate the safe head db when the derivation starts from L2 genesis. In op-program there is no safe head db recording and walking back to L1 genesis is a very expensive operation.
Tests
None yet - will follow up by adding precaptured network data to validate the first L2 block on a chain as part of the
op-program-compat
job which runs purely offline so will fail if we try to request additional block data.