Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-program: Avoid requesting L1 genesis block when starting from L2 genesis #9807

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

ajsutton
Copy link
Contributor

Description

Avoids requesting the L1 genesis block to populate the safe head db when the derivation starts from L2 genesis. In op-program there is no safe head db recording and walking back to L1 genesis is a very expensive operation.

Tests

None yet - will follow up by adding precaptured network data to validate the first L2 block on a chain as part of the op-program-compat job which runs purely offline so will fail if we try to request additional block data.

@ajsutton ajsutton requested review from protolambda, trianglesphere and a team as code owners March 10, 2024 22:50
Copy link
Contributor

coderabbitai bot commented Mar 10, 2024

Walkthrough

Walkthrough

The recent update introduces a new method Enabled() to both the DisabledDB and SafeDB structures, enabling a check on the database's status. This enhancement also affects the SafeHeadListener interface, influencing the EngineQueue's Reset function by including a validation based on the enabled status before processing the genesis block. These changes provide better control over database and safe head operations.

Changes

Files Change Summaries
.../safedb/disabled.go, .../safedb.go Added Enabled() method to DisabledDB and SafeDB, returning a boolean for the database status.
.../derive/engine_queue.go Updated SafeHeadListener with Enabled() method and added a check in Reset function.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.60%. Comparing base (f054db0) to head (cd56d18).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #9807       +/-   ##
===========================================
- Coverage    28.53%   0.60%   -27.93%     
===========================================
  Files          164      91       -73     
  Lines         7212    2461     -4751     
  Branches      1322     573      -749     
===========================================
- Hits          2058      15     -2043     
+ Misses        5048    2446     -2602     
+ Partials       106       0      -106     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests 0.60% <ø> (ø)
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 73 files with indirect coverage changes

@ajsutton ajsutton added this pull request to the merge queue Mar 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 11, 2024
@ajsutton ajsutton added this pull request to the merge queue Mar 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2024
@ajsutton ajsutton added this pull request to the merge queue Mar 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2024
@ajsutton ajsutton added this pull request to the merge queue Mar 11, 2024
Merged via the queue into develop with commit 47a1478 Mar 11, 2024
72 checks passed
@ajsutton ajsutton deleted the aj/avoid-genesis-fetch branch March 11, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants