Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op-e2e): E2E Bond Test Alphabet VM Migration #9803

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Mar 9, 2024

Description

Migrates the e2e bond test to the alphabet vm instead of cannon.

@refcell refcell requested a review from a team as a code owner March 9, 2024 19:58
@refcell refcell requested a review from trianglesphere March 9, 2024 19:58
Copy link
Contributor

coderabbitai bot commented Mar 9, 2024

Walkthrough

Walkthrough

The changes revolve around refining bond reclaiming mechanisms in dispute game scenarios. A new test function is introduced to specifically address bond reclaiming in the output alphabet game, while the bond reclaiming logic and associated test function for the output cannon have been removed, indicating a shift in how these scenarios are handled within the project.

Changes

File Path Change Summary
.../faultproofs/output_alphabet_test.go Added math/big and .../deployer imports. Added TestOutputAlphabetGame_ReclaimBond for bond reclaiming in a dispute game.
.../e2eutils/disputegame/output_game_helper.go Removed Balance method from OutputGameHelper struct. Logic for fetching balance removed from this struct.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor Author

refcell commented Mar 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell self-assigned this Mar 9, 2024
@refcell refcell requested review from ajsutton and removed request for trianglesphere March 9, 2024 19:58
@refcell refcell added A-op-e2e Area: op-e2e C-cleanup Category: General cleanup labels Mar 9, 2024
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.29%. Comparing base (f054db0) to head (c913e84).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9803       +/-   ##
============================================
+ Coverage    28.53%   82.29%   +53.75%     
============================================
  Files          164       10      -154     
  Lines         7212     1073     -6139     
  Branches      1322        0     -1322     
============================================
- Hits          2058      883     -1175     
+ Misses        5048      159     -4889     
+ Partials       106       31       -75     
Flag Coverage Δ
cannon-go-tests 82.29% <ø> (ø)
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 154 files with indirect coverage changes

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced the explicit balance amounts with just checking that the funds move properly so the test isn't dependent on specific bond amounts or user balances. But otherwise looks good.

@ajsutton ajsutton enabled auto-merge March 11, 2024 21:59
@ajsutton ajsutton added this pull request to the merge queue Mar 11, 2024
Merged via the queue into develop with commit fdd4383 Mar 11, 2024
73 checks passed
@ajsutton ajsutton deleted the refcell/alphabet-vm-bond-test branch March 11, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-e2e Area: op-e2e C-cleanup Category: General cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants