-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(op-e2e): E2E Bond Test Alphabet VM Migration #9803
Conversation
WalkthroughWalkthroughThe changes revolve around refining bond reclaiming mechanisms in dispute game scenarios. A new test function is introduced to specifically address bond reclaiming in the output alphabet game, while the bond reclaiming logic and associated test function for the output cannon have been removed, indicating a shift in how these scenarios are handled within the project. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9803 +/- ##
============================================
+ Coverage 28.53% 82.29% +53.75%
============================================
Files 164 10 -154
Lines 7212 1073 -6139
Branches 1322 0 -1322
============================================
- Hits 2058 883 -1175
+ Misses 5048 159 -4889
+ Partials 106 31 -75
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced the explicit balance amounts with just checking that the funds move properly so the test isn't dependent on specific bond amounts or user balances. But otherwise looks good.
Description
Migrates the e2e bond test to the alphabet vm instead of cannon.