feat(op-node): gater unblock

[felipe-op]

Description

This change implements the UnblockPeer in ExpiryConnectionGater so we can externally clear the node from being banned. It also automatically clears the state on authoritative disconnects.

Tests

go test ./...

Meta

Part of https://github.com/ethereum-optimism/devinfra-pod/issues/38

[coderabbitai]

Warning

Rate Limit Exceeded

@felipe-op has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 51 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between a5f3c4a and a713251.

Walkthrough

The recent updates focus on enhancing the peer connection management and logging within a P2P network module. Specifically, these changes introduce a method for unblocking peers, improve the logging for peer and address ban expiry checks, and ensure consistency in error handling and logging. Additionally, the updates refine the process of disconnecting peers by incorporating an unblock step, ensuring a cleaner disconnection and management of peer connections.

Changes

Files	Change Summary
.../gating/expiry.go	- Introduced UnblockPeer method - Enhanced logging in ban expiry checks - Improved error handling and logging consistency
.../rpc_server.go	- Added unblocking of peers in DisconnectPeer function before removal and address clearing

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.62%. Comparing base (df98e90) to head (a713251).
Report is 33 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #9763       +/-   ##
===========================================
- Coverage    28.73%   0.62%   -28.12%     
===========================================
  Files          162      89       -73     
  Lines         7144    2398     -4746     
  Branches      1309     560      -749     
===========================================
- Hits          2053      15     -2038     
+ Misses        4985    2383     -2602     
+ Partials       106       0      -106     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	?
common-ts-tests	?
contracts-bedrock-tests	0.62% <ø> (ø)
contracts-ts-tests	?
core-utils-tests	?
sdk-next-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 73 files with indirect coverage changes

[semgrep-app]

Semgrep found 10 sol-style-return-arg-fmt findings:

• packages/contracts-bedrock/scripts/Deployer.sol: L148, L126, L79, L66
• packages/contracts-bedrock/scripts/DeployPeriphery.s.sol: L28
• packages/contracts-bedrock/scripts/Artifacts.s.sol: L272, L249, L247, L240, L54

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

Semgrep found 2 sol-style-notice-over-dev-natspec findings:

• packages/contracts-bedrock/scripts/Deployer.sol: L173, L153

Prefer @notice over @dev in natspec comments

_{Ignore this finding from sol-style-notice-over-dev-natspec.}