l2ImmutableDeployer : remove contracts with no immutable

[zhiqiangxu]

l2ImmutableDeployer is used to deploy contracts with immutables and this line will stop contracts without immutables from being deployed.

This PR removes the contracts which HasImmutableReferences returns false.

[coderabbitai]

Walkthrough

The recent update involves refining the deployment logic within the l2ImmutableDeployer function. It streamlines the process by removing deployment for several components like "L2CrossDomainMessenger", "L2StandardBridge", "OptimismMintableERC20Factory", and "L2ERC721Bridge". Additionally, it fine-tunes the deployment procedures for "SequencerFeeVault" and "OptimismMintableERC721Factory", indicating a shift in focus or optimization of resources towards these elements.

Changes

Files	Change Summary
.../immutables/immutables.go	Removed deployment for "L2CrossDomainMessenger", "L2StandardBridge", "OptimismMintableERC20Factory", "L2ERC721Bridge"; adjusted deployment for "SequencerFeeVault", "OptimismMintableERC721Factory".
.../rollup/derive/ecotone_upgrade_transactions.go	Increased the capacity of the upgradeTxns slice from 5 to 6.
.../state/state.go	Added a break statement in the ComputeStorageSlots function to exit the loop early for efficiency.
.../genesis/layer_two.go	Removed a case block handling various contract names in the BuildL2Genesis function, specifically eliminating the creation of accounts for certain contracts.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[tynes]

Generally looks good to me, thank you for this fix

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.76%. Comparing base (b36eb55) to head (67959e4).
Report is 7 commits behind head on develop.

❗ Current head 67959e4 differs from pull request most recent head f5e96ef. Consider uploading reports for the commit f5e96ef to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #9723      +/-   ##
===========================================
- Coverage    28.73%   25.76%   -2.98%     
===========================================
  Files          162       99      -63     
  Lines         7144     3466    -3678     
  Branches      1309      560     -749     
===========================================
- Hits          2053      893    -1160     
+ Misses        4985     2542    -2443     
+ Partials       106       31      -75     

Flag	Coverage Δ
cannon-go-tests	82.20% <ø> (ø)
chain-mon-tests	?
common-ts-tests	?
contracts-bedrock-tests	0.62% <ø> (ø)
contracts-ts-tests	?
core-utils-tests	?
sdk-next-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes