-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final version for Kontrol pausability proofs #9530
Final version for Kontrol pausability proofs #9530
Conversation
packages/contracts-bedrock/test/kontrol/proofs/L1CrossDomainMessenger.k.sol
Show resolved
Hide resolved
packages/contracts-bedrock/test/kontrol/proofs/OptimismPortal.k.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/test/kontrol/proofs/OptimismPortal.k.sol
Outdated
Show resolved
Hide resolved
WalkthroughWalkthroughThe recent updates aim to streamline test execution and deployment processes for Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
We run `run-kontrol.sh` with the `script` option to avoid executing all proofs
The longer the `_withdrawalProof` array the longer the execution time Adding the lengths 0 and 1 fits within the max cpus and won't take as long to run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but need to add the filter to ensure Kontrol doesn't run on every scheduled trigger.
876e16a
Description
Building on #9183, this PR wraps up the existing pausability proofs by adding the following:
bytes
andbytes[]
mockCall
workaround with thevm.mockCall
cheatcodestartPrank
workaround with the appropriatevm.prank
cheatcodeTests
No additional tests are added so far. This PR modifies the existing proofs to include all the latest and necessary improvements.
Additional context
Before this PR, a number of workarounds were in place to have these proofs pass. These workarounds didn't threaten the soundness of the proofs, but they affected long-term maintainability, execution performance, and the generality of the proofs.