Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps @eth-optimism/contracts-bedrock #9415

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

nitaliano
Copy link
Contributor

Description

Bumps @eth-optimism/contracts-bedrock so fpac contracts exist for the SDK on lookup.

When I pull in the latest SDK version on the develop branch it's resolving to 0.16.2 this is 4 months old and doesn't have the DisputeGameFactory & OptimismPortal2 json in it.

Results in anything that consumes the SDK to crash on startup

Uncaught TypeError: Failed to resolve module specifier "@eth-optimism/contracts-bedrock/forge-artifacts/DisputeGameFactory.sol/DisputeGameFactory.json". Relative references must start with either "/", "./", or "../".

The code for the above errors is happening over here

Copy link
Contributor

coderabbitai bot commented Feb 7, 2024

Walkthrough

Walkthrough

The change introduces a patch to update the version of @eth-optimism/contracts-bedrock. This update ensures that the fpac contracts are available for the SDK, aiming to improve functionality and possibly address issues related to SDK bloat by optimizing the contracts that are included.

Changes

File Changes Summary of Changes
.changeset/rotten-dots-destroy.md Introduced a patch to bump @eth-optimism/contracts-bedrock version.

Related issues

  • Decrease SDK size / introduce submodules #9235: The patch for @eth-optimism/contracts-bedrock could indirectly contribute to reducing the SDK size by ensuring only necessary contracts are included, aligning with the objective to streamline the SDK's components.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@tynes tynes added this pull request to the merge queue Feb 7, 2024
Merged via the queue into develop with commit 79effc5 Feb 7, 2024
64 checks passed
@tynes tynes deleted the bump-contracts-bedrock-npm-version branch February 7, 2024 16:03
@github-actions github-actions bot mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants