Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: genesis deduplicate json write #9323

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Feb 2, 2024

Description

Deduplicate code by using a common json write function from
op-service instead of using one off json write functions.
This reduces the overall code in the codebase and helps to
standardize the way that we write json to disk.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Deduplicate code by using a common json write function from
`op-service` instead of using one off json write functions.
This reduces the overall code in the codebase and helps to
standardize the way that we write json to disk.
@tynes tynes requested a review from a team as a code owner February 2, 2024 17:32
@tynes tynes requested a review from protolambda February 2, 2024 17:32
Copy link
Contributor

coderabbitai bot commented Feb 2, 2024

Walkthrough

Walkthrough

The modification simplifies the process of writing JSON files in the project by eliminating the bespoke writeJSONFile function. Instead, it leverages a more standardized approach through the use of jsonutil.WriteJSON utility for handling JSON data related to l1Genesis, l2Genesis, and rollupConfig. This change streamlines the codebase, enhancing maintainability and consistency in handling JSON outputs.

Changes

File Path Change Summary
op-node/cmd/genesis/cmd.go Replaced direct file writing with jsonutil.WriteJSON for l1Genesis, l2Genesis, and rollupConfig; removed writeJSONFile function.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b33f33) 27.86% compared to head (89b18a6) 0.65%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #9323       +/-   ##
===========================================
- Coverage    27.86%   0.65%   -27.21%     
===========================================
  Files          167      88       -79     
  Lines         7357    2289     -5068     
  Branches      1271     536      -735     
===========================================
- Hits          2050      15     -2035     
+ Misses        5186    2274     -2912     
+ Partials       121       0      -121     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests 0.65% <ø> (ø)
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 79 files with indirect coverage changes

@tynes tynes added this pull request to the merge queue Feb 2, 2024
Merged via the queue into develop with commit 0ea5e0b Feb 2, 2024
69 checks passed
@tynes tynes deleted the cleanup/op-node-dedupe-json branch February 2, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants