Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy from address for calls #85

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Add dummy from address for calls #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbd0081
add dummy from address for calls
K-Ho Apr 15, 2020
3d4ec8c
lint
K-Ho Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/rollup-full-node/src/app/web3-rpc-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,11 @@ export class DefaultWeb3Handler
txObject
)}], defaultBlock: [${defaultBlock}]`
)
// TODO allow executing a call without a from address
// Currently using a dummy default from_address
if (!txObject['from']) {
txObject['from'] = '0x' + '88'.repeat(20)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎱 🎱

}
// First generate the internalTx calldata
const internalCalldata = this.getTransactionCalldata(
this.getTimestamp(),
Expand Down