Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eas: update version to v1.3.0 #8099

Merged
merged 4 commits into from
Nov 8, 2023
Merged

eas: update version to v1.3.0 #8099

merged 4 commits into from
Nov 8, 2023

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Nov 8, 2023

Description

Small update to #8085
to bump semantic version.

In this PR, we have improved delegated attestations/revocations by additionally committing to the address of the attester/revoker in the EIP712 signature itself. The recently released EAS SDK already supports this new version of delegated attestations/revocations (via ethereum-attestation-service/eas-sdk#68)

lbeder and others added 4 commits November 7, 2023 22:43
Small update to #8085
to bump semantic version.

> In this PR, we have improved delegated attestations/revocations by additionally
  committing to the address of the attester/revoker in the EIP712 signature itself.
  The recently released EAS SDK already supports this new version of delegated
  attestations/revocations (via ethereum-attestation-service/eas-sdk#68)
@tynes tynes requested a review from a team as a code owner November 8, 2023 09:21
@tynes tynes requested a review from maurelian November 8, 2023 09:21
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #8099 (7772c05) into develop (a281abb) will decrease coverage by 3.63%.
Report is 41 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #8099      +/-   ##
===========================================
- Coverage    44.89%   41.27%   -3.63%     
===========================================
  Files          171      123      -48     
  Lines         7214     4834    -2380     
  Branches      1150      999     -151     
===========================================
- Hits          3239     1995    -1244     
+ Misses        3833     2766    -1067     
+ Partials       142       73      -69     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests ?
contracts-bedrock-tests 39.02% <ø> (+1.36%) ⬆️
contracts-ts-tests 100.00% <ø> (ø)
core-utils-tests ?
sdk-next-tests 41.92% <ø> (ø)
sdk-tests 41.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/contracts-bedrock/src/EAS/EAS.sol 0.00% <ø> (ø)
...tracts-bedrock/src/EAS/eip1271/EIP1271Verifier.sol 0.00% <ø> (ø)

... and 55 files with indirect coverage changes

@tynes tynes merged commit e3301a6 into develop Nov 8, 2023
4 checks passed
@tynes tynes deleted the eas/update-version branch November 8, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants