Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of 'Immutable' for variables storing keccak hashes #8024

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

0xScratch
Copy link
Contributor

Description

Replaced 'constant' with 'immutable' on the basis of these two links -> 1st and 2nd
This seems more effective.

Tests

No tests added cuz it wasn't necessary!

@0xScratch 0xScratch requested a review from a team as a code owner November 3, 2023 08:23
@0xScratch 0xScratch requested a review from Inphi November 3, 2023 08:23
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #8024 (ce1b1e3) into develop (3e890bb) will increase coverage by 0.07%.
Report is 20 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #8024      +/-   ##
===========================================
+ Coverage    46.01%   46.08%   +0.07%     
===========================================
  Files          170      170              
  Lines         7121     7121              
  Branches      1138     1138              
===========================================
+ Hits          3277     3282       +5     
+ Misses        3717     3712       -5     
  Partials       127      127              
Flag Coverage Δ
cannon-go-tests 63.47% <ø> (ø)
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests 26.74% <ø> (ø)
contracts-bedrock-tests 40.33% <ø> (+0.17%) ⬆️
contracts-ts-tests 100.00% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-next-tests 41.92% <ø> (ø)
sdk-tests 41.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...phery/faucet/authmodules/AdminFaucetAuthModule.sol 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Unfortunate constant behavior. Thanks for fixing.

@Inphi Inphi enabled auto-merge November 3, 2023 17:26
@Inphi Inphi added this pull request to the merge queue Nov 3, 2023
Merged via the queue into ethereum-optimism:develop with commit 76c4420 Nov 3, 2023
62 checks passed
@0xScratch 0xScratch deleted the patch-1 branch November 3, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants