Migrate bedrock-devnet to go #6710

refcell · 2023-08-11T00:09:38Z

Description

Migrates and refactors the bedrock-devnet/ to golang
in a new ops-devnet package.

changeset-bot · 2023-08-11T00:09:41Z

⚠️ No Changeset found

Latest commit: 53e5c5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

refcell · 2023-08-11T00:09:49Z

Current dependencies on/for this PR:

develop
- PR Migrate bedrock-devnet to go #6710 👈

This comment was auto-generated by Graphite.

semgrep-app · 2023-08-11T00:10:17Z

ops-devnet/utils/json.go

+// WriteJson writes the [target] to [path] as JSON.
+func WriteJson(path string, target interface{}) error {
+	file, _ := json.MarshalIndent(target, "", " ")
+	return ioutil.WriteFile(path, file, 0644)


ioutil.WriteFile is deprecated

Suggested change

return ioutil.WriteFile(path, file, 0644)

return os.WriteFile(path, file, 0644)

_{Ignore this finding from deprecated-ioutil-writefile.}

semgrep-app · 2023-08-11T00:10:19Z

ops-devnet/genesis/genesis.go

+	if err != nil {
+		return err
+	}
+	err = ioutil.WriteFile(devnetConfigPath, data, 0644)


ioutil.WriteFile is deprecated

Suggested change

err = ioutil.WriteFile(devnetConfigPath, data, 0644)

err = os.WriteFile(devnetConfigPath, data, 0644)

_{Ignore this finding from deprecated-ioutil-writefile.}

semgrep-app · 2023-08-11T00:10:20Z

ops-devnet/genesis/genesis.go

+    if err != nil {
+		return err
+	}
+    err = ioutil.WriteFile(devnetConfigBackup, data, 0644)


ioutil.WriteFile is deprecated

Suggested change

err = ioutil.WriteFile(devnetConfigBackup, data, 0644)

err = os.WriteFile(devnetConfigBackup, data, 0644)

_{Ignore this finding from deprecated-ioutil-writefile.}

semgrep-app · 2023-08-11T00:10:22Z

ops-devnet/allocs/allocs.go

+    if err != nil {
+		return err
+	}
+    err = ioutil.WriteFile(utils.AddressesJsonPath(monorepo), data, 0644)


ioutil.WriteFile is deprecated

Suggested change

err = ioutil.WriteFile(utils.AddressesJsonPath(monorepo), data, 0644)

err = os.WriteFile(utils.AddressesJsonPath(monorepo), data, 0644)

_{Ignore this finding from deprecated-ioutil-writefile.}

semgrep-app · 2023-08-11T00:10:23Z

ops-devnet/genesis/genesis.go

+	devnetConfigPath := utils.DevnetConfigPath(monorepo)
+	devnetConfigBackup := utils.DevnetConfigBackup(monorepo)
+
+	data, err := ioutil.ReadFile(devnetConfigBackup)


ioutil.ReadFile is deprecated

Suggested change

data, err := ioutil.ReadFile(devnetConfigBackup)

data, err := os.ReadFile(devnetConfigBackup)

_{Ignore this finding from deprecated-ioutil-readfile.}

semgrep-app · 2023-08-11T00:10:25Z

ops-devnet/genesis/genesis.go

+	devnetConfigPath := utils.DevnetConfigPath(monorepo)
+	devnetConfigBackup := utils.DevnetConfigBackup(monorepo)
+
+	data, err := ioutil.ReadFile(devnetConfigPath)


ioutil.ReadFile is deprecated

Suggested change

data, err := ioutil.ReadFile(devnetConfigPath)

data, err := os.ReadFile(devnetConfigPath)

_{Ignore this finding from deprecated-ioutil-readfile.}

semgrep-app · 2023-08-11T00:10:26Z

ops-devnet/devnet/devnet.go

+
+// ReadeBatchInboxAddress reads the batch inbox address from the rollup.json file.
+func ReadeBatchInboxAddress(monorepo string) (string, error) {
+	data, err := ioutil.ReadFile(utils.RollupPath(monorepo))


ioutil.ReadFile is deprecated

Suggested change

data, err := ioutil.ReadFile(utils.RollupPath(monorepo))

data, err := os.ReadFile(utils.RollupPath(monorepo))

_{Ignore this finding from deprecated-ioutil-readfile.}

semgrep-app · 2023-08-11T00:10:28Z

ops-devnet/devnet/devnet.go

+
+// ReadL2OutputOracleAddress reads the L2 output oracle address from the addresses.json file.
+func ReadL2OutputOracleAddress(monorepo string) (string, error) {
+	data, err := ioutil.ReadFile(utils.AddressesJsonPath(monorepo))


ioutil.ReadFile is deprecated

Suggested change

data, err := ioutil.ReadFile(utils.AddressesJsonPath(monorepo))

data, err := os.ReadFile(utils.AddressesJsonPath(monorepo))

_{Ignore this finding from deprecated-ioutil-readfile.}

semgrep-app · 2023-08-11T00:10:29Z

ops-devnet/allocs/allocs.go

+		return err
+	}
+
+	data, err := ioutil.ReadFile(utils.L1DeploymentsPath(monorepo))


ioutil.ReadFile is deprecated

Suggested change

data, err := ioutil.ReadFile(utils.L1DeploymentsPath(monorepo))

data, err := os.ReadFile(utils.L1DeploymentsPath(monorepo))

_{Ignore this finding from deprecated-ioutil-readfile.}

semgrep-app · 2023-08-11T00:10:31Z

ops-devnet/genesis/genesis.go

+	if err != nil {
+		return err
+	}
+	return nil


superfluous nil err check before return
_{Ignore this finding from err-nil-check.}

tynes · 2023-08-23T04:47:03Z

I am not opposed to this, its a bit easier to do async stuff in go compared to python, but it feels like a bit of thrashing because what we have already works

codecov · 2023-08-23T14:46:52Z

Codecov Report

Merging #6710 (e2b9855) into develop (cfa5e24) will increase coverage by 2.99%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6710      +/-   ##
===========================================
+ Coverage    45.36%   48.35%   +2.99%     
===========================================
  Files          383      315      -68     
  Lines        29945    23734    -6211     
  Branches      1692        0    -1692     
===========================================
- Hits         13584    11477    -2107     
+ Misses       14904    11230    -3674     
+ Partials      1457     1027     -430

Flag	Coverage Δ
bedrock-go-tests	`48.35% <ø> (-0.03%)`	⬇️
cannon-go-tests	`?`
chain-mon-tests	`?`
common-ts-tests	`?`
contracts-bedrock-tests	`?`
contracts-ts-tests	`?`
core-utils-tests	`?`
sdk-next-tests	`?`
sdk-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 77 files with indirect coverage changes

github-actions · 2023-09-07T01:46:14Z

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

semgrep-app bot reviewed Aug 11, 2023

View reviewed changes

refcell self-assigned this Aug 11, 2023

refcell added C-spike Category: Performs a spike H-bedrock-devnet Hardfork: bedrock-devnet labels Aug 16, 2023

refcell changed the title ~~feat(ops-devnet): Migrate bedrock-devnet to go~~ Migrate bedrock-devnet to go Aug 16, 2023

trajan0x mentioned this pull request Aug 23, 2023

make usage of docker compose v2 explicit #6972

Merged

Migrate devnet operations to golang.

e2b9855

refcell force-pushed the refcell/ops-bedrock branch from 53e5c5a to e2b9855 Compare August 23, 2023 14:39

github-actions bot added the Stale label Sep 7, 2023

refcell closed this Sep 7, 2023

trajan0x mentioned this pull request Sep 15, 2023

Devnet synapsecns/sanguine#1381

Merged

4 tasks

refcell deleted the refcell/ops-bedrock branch September 19, 2023 15:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate bedrock-devnet to go #6710

Migrate bedrock-devnet to go #6710

refcell commented Aug 11, 2023

changeset-bot bot commented Aug 11, 2023

refcell commented Aug 11, 2023 •

edited

Loading

semgrep-app bot Aug 11, 2023

semgrep-app bot Aug 11, 2023

semgrep-app bot Aug 11, 2023

semgrep-app bot Aug 11, 2023

semgrep-app bot Aug 11, 2023

semgrep-app bot Aug 11, 2023

semgrep-app bot Aug 11, 2023

semgrep-app bot Aug 11, 2023

semgrep-app bot Aug 11, 2023

semgrep-app bot Aug 11, 2023

tynes commented Aug 23, 2023

codecov bot commented Aug 23, 2023 •

edited

Loading

github-actions bot commented Sep 7, 2023

	return ioutil.WriteFile(path, file, 0644)
	return os.WriteFile(path, file, 0644)

	err = ioutil.WriteFile(devnetConfigPath, data, 0644)
	err = os.WriteFile(devnetConfigPath, data, 0644)

	err = ioutil.WriteFile(devnetConfigBackup, data, 0644)
	err = os.WriteFile(devnetConfigBackup, data, 0644)

	err = ioutil.WriteFile(utils.AddressesJsonPath(monorepo), data, 0644)
	err = os.WriteFile(utils.AddressesJsonPath(monorepo), data, 0644)

	data, err := ioutil.ReadFile(devnetConfigBackup)
	data, err := os.ReadFile(devnetConfigBackup)

	data, err := ioutil.ReadFile(devnetConfigPath)
	data, err := os.ReadFile(devnetConfigPath)

	data, err := ioutil.ReadFile(utils.RollupPath(monorepo))
	data, err := os.ReadFile(utils.RollupPath(monorepo))

	data, err := ioutil.ReadFile(utils.AddressesJsonPath(monorepo))
	data, err := os.ReadFile(utils.AddressesJsonPath(monorepo))

	data, err := ioutil.ReadFile(utils.L1DeploymentsPath(monorepo))
	data, err := os.ReadFile(utils.L1DeploymentsPath(monorepo))

Migrate bedrock-devnet to go #6710

Migrate bedrock-devnet to go #6710

Conversation

refcell commented Aug 11, 2023

changeset-bot bot commented Aug 11, 2023

⚠️ No Changeset found

refcell commented Aug 11, 2023 • edited Loading

semgrep-app bot Aug 11, 2023

Choose a reason for hiding this comment

semgrep-app bot Aug 11, 2023

Choose a reason for hiding this comment

semgrep-app bot Aug 11, 2023

Choose a reason for hiding this comment

semgrep-app bot Aug 11, 2023

Choose a reason for hiding this comment

semgrep-app bot Aug 11, 2023

Choose a reason for hiding this comment

semgrep-app bot Aug 11, 2023

Choose a reason for hiding this comment

semgrep-app bot Aug 11, 2023

Choose a reason for hiding this comment

semgrep-app bot Aug 11, 2023

Choose a reason for hiding this comment

semgrep-app bot Aug 11, 2023

Choose a reason for hiding this comment

semgrep-app bot Aug 11, 2023

Choose a reason for hiding this comment

tynes commented Aug 23, 2023

codecov bot commented Aug 23, 2023 • edited Loading

Codecov Report

github-actions bot commented Sep 7, 2023

refcell commented Aug 11, 2023 •

edited

Loading

codecov bot commented Aug 23, 2023 •

edited

Loading