Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fee-estimation): Multiply gas fee in estimate gas #6609

Merged

Conversation

roninjin10
Copy link
Contributor

Bug in fee estimation package. Did not multiply the gas fee

  • Fix via multiplying the gas fee
  • Must mock this out in a unit test because there is no way for viem to get a historical gas fee via viem.publicClient.estimateGas

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2023

🦋 Changeset detected

Latest commit: 0a98fbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/fee-estimation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@roninjin10
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@roninjin10 roninjin10 force-pushed the 08-05-fix_fee-estimation_Multiply_gas_fee_in_estimate_gas branch from acb24fa to 2fbe51d Compare August 5, 2023 10:55
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #6609 (0a98fbb) into develop (556e5ad) will increase coverage by 2.93%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6609      +/-   ##
===========================================
+ Coverage    44.54%   47.47%   +2.93%     
===========================================
  Files          374      307      -67     
  Lines        29364    23176    -6188     
  Branches      1688        0    -1688     
===========================================
- Hits         13079    11003    -2076     
+ Misses       14858    11175    -3683     
+ Partials      1427      998     -429     
Flag Coverage Δ
bedrock-go-tests 47.47% <ø> (+0.02%) ⬆️
cannon-go-tests ?
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 76 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 58a2d89 into develop Aug 6, 2023
@OptimismBot OptimismBot deleted the 08-05-fix_fee-estimation_Multiply_gas_fee_in_estimate_gas branch August 6, 2023 18:30
@mergify mergify bot removed the on-merge-train label Aug 6, 2023
@github-actions github-actions bot mentioned this pull request Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants