Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changeset versioning and release scripts #6355

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

roninjin10
Copy link
Contributor

@roninjin10 roninjin10 commented Jul 19, 2023

This fixes issue with pnpm lockfile being out of date

  • failed to update the github action to use the new release:version and release:publish scripts I added
  • Noticed that we are pnpm installing after building which is backwards

Note the pnpm install isn't doing anything it's there it is there as a safeguard to prevent bad publishes

@roninjin10 roninjin10 requested a review from a team as a code owner July 19, 2023 18:40
@roninjin10 roninjin10 requested review from mslipper and removed request for a team July 19, 2023 18:40
@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

⚠️ No Changeset found

Latest commit: 7f9002e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@roninjin10 roninjin10 mentioned this pull request Jul 19, 2023
@roninjin10
Copy link
Contributor Author

roninjin10 commented Jul 19, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

⚠️ The sha of the head commit of this PR conflicts with #6340. Mergify cannot evaluate rules on this PR. ⚠️

@roninjin10 roninjin10 changed the base branch from changeset-release/develop to develop July 19, 2023 18:40
@roninjin10 roninjin10 force-pushed the willc/versioning-release-fix branch from 5536182 to 2d5533f Compare July 19, 2023 18:41
@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 7f9002e
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64b8387d09d2480008b3cad7

@roninjin10 roninjin10 changed the title fix: Fix changeset versioning and release scripts fix: Changeset versioning and release scripts Jul 19, 2023
@roninjin10 roninjin10 requested a review from tynes July 19, 2023 18:41
@roninjin10 roninjin10 force-pushed the willc/versioning-release-fix branch from 2d5533f to 10b7346 Compare July 19, 2023 19:03
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #6355 (7f9002e) into develop (bb8ae92) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6355      +/-   ##
===========================================
+ Coverage    44.94%   44.95%   +0.01%     
===========================================
  Files          449      449              
  Lines        29263    29263              
  Branches       748      748              
===========================================
+ Hits         13151    13155       +4     
+ Misses       15043    15040       -3     
+ Partials      1069     1068       -1     
Flag Coverage Δ
bedrock-go-tests 43.64% <ø> (+0.01%) ⬆️
cannon-go-tests 62.40% <ø> (ø)
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 63.36% <ø> (ø)
core-utils-tests 44.24% <ø> (ø)
fault-detector-tests 26.95% <ø> (ø)
sdk-next-tests 42.48% <ø> (ø)
sdk-tests 42.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@OptimismBot OptimismBot merged commit 5eb852b into develop Jul 19, 2023
@mergify mergify bot removed the on-merge-train label Jul 19, 2023
@smartcontracts smartcontracts deleted the willc/versioning-release-fix branch October 22, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants