-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contracts-bedrock: delete dead typescript #6148
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
Hey @tynes! This PR has merge conflicts. Please fix them before continuing review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woot woot 🎉
Hey @tynes! This PR has merge conflicts. Please fix them before continuing review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending ci
Will rebase on #6152 |
This commit deletes a bunch of dead typescript code from the contracts-bedrock package. This deletes bundling in all of the artifacts into the npm package so it will make the npm package must smaller. It will also reduce the build time by removing some steps from the build.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6148 +/- ##
===========================================
+ Coverage 44.63% 44.75% +0.12%
===========================================
Files 441 442 +1
Lines 28931 29011 +80
Branches 675 691 +16
===========================================
+ Hits 12912 12983 +71
- Misses 14968 14976 +8
- Partials 1051 1052 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
This commit deletes a bunch of dead typescript code from the contracts-bedrock package.
This deletes bundling in all of the artifacts into the npm package so it will make the npm package must smaller. It will also reduce the build time by removing some steps from the build.