-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): check for both v0 and v1 messages when looking for RelayedMessages #6042
Conversation
🦋 Changeset detectedLatest commit: 650eba7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for opstack-docs canceled.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
875f2b7
to
2711479
Compare
698e4d7
to
95511d2
Compare
Semgrep found 2 Unchecked type assertion. Ignore this finding from unchecked-type-assertion. |
bcf9ec4
to
be79fe0
Compare
Hey @roninjin10! This PR has merge conflicts. Please fix them before continuing review. |
be79fe0
to
549ac7f
Compare
549ac7f
to
9799097
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6042 +/- ##
========================================
Coverage 44.56% 44.56%
========================================
Files 412 412
Lines 26268 26269 +1
Branches 684 684
========================================
+ Hits 11706 11707 +1
Misses 13573 13573
Partials 989 989
Flags with carried forward coverage won't be shown. Click here to find out more.
|
39800c6
to
9799097
Compare
ab3a539
to
9799097
Compare
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
…essages test: add one fix: linter fix: Failed to save file to change failed ones too fix: linter Fix --fork-block-number to correct network block number changeset
79c1ecd
to
89ca741
Compare
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Fixes #6035
Bug explanation
To figure out if a message is relayed we check for
RelayedMessage
event for message hashFix
Check for both v0 and v1