Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add acceptance test for BLS precompiles #13934

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

meyer9
Copy link
Contributor

@meyer9 meyer9 commented Jan 23, 2025

Description

Adds a test showing that BLS precompiles work when Isthmus is enabled as specified in EIP-2537.

Blocked by ethereum-optimism/op-geth#472

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.32%. Comparing base (192e511) to head (f1842f3).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13934      +/-   ##
===========================================
- Coverage    45.60%   41.32%   -4.28%     
===========================================
  Files         1006      841     -165     
  Lines        85982    76667    -9315     
===========================================
- Hits         39208    31682    -7526     
+ Misses       43796    42178    -1618     
+ Partials      2978     2807     -171     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 176 files with indirect coverage changes

@meyer9 meyer9 force-pushed the meyer9/isthmus-e2e-fixes branch from 4af4468 to 1383b3b Compare January 28, 2025 15:50
@meyer9 meyer9 force-pushed the meyer9/isthmus-bls-test branch from 7bb33f9 to 028da1f Compare February 5, 2025 01:29
@meyer9 meyer9 changed the base branch from meyer9/isthmus-e2e-fixes to develop February 5, 2025 01:29
@meyer9 meyer9 marked this pull request as ready for review February 5, 2025 01:29
@meyer9 meyer9 requested review from a team as code owners February 5, 2025 01:29
@meyer9 meyer9 requested a review from sebastianst February 5, 2025 01:29
@meyer9
Copy link
Contributor Author

meyer9 commented Feb 5, 2025

Sorry this is still waiting on op-geth changes to add the precompiles in.

@meyer9 meyer9 marked this pull request as draft February 5, 2025 16:43
@meyer9 meyer9 force-pushed the meyer9/isthmus-bls-test branch from 9627b9a to 6de8dd6 Compare February 6, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant