-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Isthmus] Add missing Isthmus activation time updates #13549
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13549 +/- ##
===========================================
- Coverage 47.25% 47.13% -0.13%
===========================================
Files 958 958
Lines 80075 80082 +7
Branches 773 773
===========================================
- Hits 37836 37743 -93
- Misses 39335 39449 +114
+ Partials 2904 2890 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dcb376f
to
ec0418f
Compare
@@ -252,7 +252,7 @@ require ( | |||
rsc.io/tmplfunc v0.0.3 // indirect | |||
) | |||
|
|||
replace github.com/ethereum/go-ethereum => github.com/ethereum-optimism/op-geth v1.101411.5-rc.1 | |||
replace github.com/ethereum/go-ethereum => github.com/ethereum-optimism/op-geth v1.101411.5-rc.1.0.20241219170731-928070c7fc09 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulls in this fix: ethereum-optimism/op-geth@928070c, which is not part of a release yet
cc @vdamle |
@mdehoog I see I missed a few of the timestamp activation fields in #12847 , thanks for adding these! For the addition of withdrawalsRoot fields to the structs, i've got those changes in #12848 -- that PR will likely take longer to review, so I'm happy to rebase these changes assuming this one lands first. |
Thank you for this, working towards merging this |
ec0418f
to
72a0379
Compare
Ideally we can merge ethereum-optimism/op-geth#452, cut an rc and then rebase on top of that |
Closing this, was cherry picked into another PR |
Description
As I was implementing #13539, I came across a bunch of what appears to be missing Isthmus updates. This PR adds:
L2GenesisIsthmusTimeOffset
/IsthmusTime
setsWithdrawalsRoot
engine API valueDeployConfig
=> genesisSystemConfig
conversion (there were two duplicate implementations).Tests
No new tests added. Adding the Isthmus activation before the Interop activation means the Isthmus code is now being tested by the interop tests (which is what showed up the missing
WithdrawalsRoot
sets).We may want to add
OP_E2E_USE_ISTHMUS
to the E2E environmment?