Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: Support output files in bootstrap #13302

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Dec 6, 2024

No description provided.

@mslipper mslipper requested a review from a team as a code owner December 6, 2024 22:06
@mslipper mslipper requested a review from tynes December 6, 2024 22:06
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 118 lines in your changes missing coverage. Please review.

Project coverage is 42.25%. Comparing base (6de3799) to head (9346feb).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/bootstrap/delayed_weth.go 0.00% 25 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/dispute_game.go 0.00% 24 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/asterisc.go 0.00% 22 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/proxy.go 0.00% 22 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/mips.go 0.00% 21 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/opcm.go 0.00% 2 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/superchain.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13302      +/-   ##
===========================================
- Coverage    46.75%   42.25%   -4.50%     
===========================================
  Files          927      758     -169     
  Lines        77954    68223    -9731     
  Branches       849        0     -849     
===========================================
- Hits         36445    28827    -7618     
+ Misses       38893    37004    -1889     
+ Partials      2616     2392     -224     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/bootstrap/flags.go 0.00% <ø> (ø)
op-deployer/pkg/deployer/bootstrap/opcm.go 47.53% <0.00%> (-0.30%) ⬇️
op-deployer/pkg/deployer/bootstrap/superchain.go 32.66% <0.00%> (-0.22%) ⬇️
op-deployer/pkg/deployer/bootstrap/mips.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/bootstrap/asterisc.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/bootstrap/proxy.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/bootstrap/dispute_game.go 15.95% <0.00%> (-0.61%) ⬇️
op-deployer/pkg/deployer/bootstrap/delayed_weth.go 9.15% <0.00%> (-0.31%) ⬇️

... and 179 files with indirect coverage changes

@mslipper mslipper added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit d6106dd Dec 6, 2024
42 checks passed
@mslipper mslipper deleted the bugfix/outfile-bootstrap branch December 6, 2024 22:31
sigma pushed a commit that referenced this pull request Dec 19, 2024
* op-deployer: Support output files in bootstrap

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants