Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove go-mod-download #13277

Merged
merged 1 commit into from
Dec 6, 2024
Merged

ci: Remove go-mod-download #13277

merged 1 commit into from
Dec 6, 2024

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Dec 6, 2024

No description provided.

@mslipper mslipper requested a review from a team as a code owner December 6, 2024 03:01
@mslipper mslipper requested a review from refcell December 6, 2024 03:01
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.93%. Comparing base (53b3af7) to head (c12d82a).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13277      +/-   ##
===========================================
- Coverage    46.95%   43.93%   -3.02%     
===========================================
  Files          923      810     -113     
  Lines        77648    72553    -5095     
  Branches       849        0     -849     
===========================================
- Hits         36456    31875    -4581     
+ Misses       38584    38126     -458     
+ Partials      2608     2552      -56     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.72% <ø> (-1.66%) ⬇️
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 127 files with indirect coverage changes

Copy link
Contributor

@geoknee geoknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some context about this change? Does it reduce running time on CI?

@mslipper
Copy link
Collaborator Author

mslipper commented Dec 6, 2024

This job was used to warm CircleCI's build cache. Now that we use a custom build box, there's no need to do this anymore since the task runners on the box share a local Go build cache.

@mslipper mslipper added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@mslipper mslipper added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit 7c8d28d Dec 6, 2024
42 checks passed
@mslipper mslipper deleted the feat/remove-go-mod-download branch December 6, 2024 16:12
sigma pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants