Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-deployer: Update OPCM bootstrap command #13238

Merged
merged 3 commits into from
Dec 4, 2024
Merged

op-deployer: Update OPCM bootstrap command #13238

merged 3 commits into from
Dec 4, 2024
+460 −157

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Dec 4, 2024

Updates the OPCM bootstrap command to allow bootstrapping Holocene.

@mslipper mslipper requested review from a team as code owners December 4, 2024 20:05
@mslipper mslipper requested a review from axelKingsley December 4, 2024 20:05
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.34091% with 105 lines in your changes missing coverage. Please review.

Project coverage is 42.86%. Comparing base (260f36e) to head (a261a2d).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/bootstrap/opcm.go 52.94% 34 Missing and 6 partials ⚠️
op-deployer/pkg/deployer/opcm/script.go 0.00% 28 Missing ⚠️
op-deployer/pkg/deployer/opcm/opcm.go 0.00% 12 Missing ⚠️
op-deployer/pkg/env/host.go 58.62% 8 Missing and 4 partials ⚠️
op-deployer/pkg/deployer/standard/standard.go 66.66% 4 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/asterisc.go 0.00% 3 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/flags.go 0.00% 3 Missing ⚠️
op-service/testutils/anvil/anvil.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #13238      +/-   ##
===========================================
- Coverage    45.76%   42.86%   -2.91%     
===========================================
  Files          926      754     -172     
  Lines        79531    68048   -11483     
  Branches      1133        0    -1133     
===========================================
- Hits         36400    29170    -7230     
+ Misses       40468    36404    -4064     
+ Partials      2663     2474     -189
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/bootstrap/asterisc.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/bootstrap/flags.go 0.00% <0.00%> (ø)
op-service/testutils/anvil/anvil.go 66.21% <25.00%> (-2.80%) ⬇️
op-deployer/pkg/deployer/standard/standard.go 52.59% <66.66%> (+2.99%) ⬆️
op-deployer/pkg/deployer/opcm/opcm.go 0.00% <0.00%> (ø)
op-deployer/pkg/env/host.go 69.38% <58.62%> (-15.62%) ⬇️
op-deployer/pkg/deployer/opcm/script.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/bootstrap/opcm.go 47.82% <52.94%> (+47.82%) ⬆️

... and 189 files with indirect coverage changes

@maurelian
Copy link
Contributor

Closing this for now.

@maurelian maurelian closed this Dec 4, 2024
@mslipper mslipper reopened this Dec 4, 2024
blmalone
blmalone approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maurelian
Copy link
Contributor

Closing this for now.

wrong PR, my bad.

@mslipper
op-deployer: Update OPCM bootstrap command
a07c828 
Updates the OPCM bootstrap command to allow bootstrapping Holocene.
@mslipper mslipper force-pushed the feat/op-deployer-holocene-bootstrap branch from 725cf32 to a07c828 Compare December 4, 2024 22:55
@mslipper mslipper enabled auto-merge December 4, 2024 22:55
@mslipper mslipper added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@mslipper mslipper added this pull request to the merge queue Dec 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 4, 2024
@mslipper
op-deployer: Update OPCM bootstrap command (#13238)
9667292 
Updates the OPCM bootstrap command to allow bootstrapping Holocene.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@mslipper mslipper enabled auto-merge December 4, 2024 23:14
@mslipper mslipper added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit d3fbc57 Dec 4, 2024
45 checks passed
@mslipper mslipper deleted the feat/op-deployer-holocene-bootstrap branch December 4, 2024 23:34
sigma pushed a commit that referenced this pull request Dec 19, 2024
@mslipper @sigma
op-deployer: Update OPCM bootstrap command (#13238)
5699044 
* op-deployer: Update OPCM bootstrap command

Updates the OPCM bootstrap command to allow bootstrapping Holocene.

* fix merge artifact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blmalone blmalone blmalone approved these changes

@axelKingsley axelKingsley Awaiting requested review from axelKingsley axelKingsley is a code owner automatically assigned from ethereum-optimism/op-stack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mslipper @maurelian @blmalone