Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: rewrite spacers check to use new framework #13232

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

smartcontracts
Copy link
Contributor

Updates the spacers check to use the new framework for contracts checks written in Go. Adds tests for the functions that this check uses.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Updates the spacers check to use the new framework for contracts
checks written in Go. Adds tests for the functions that this
check uses.
@smartcontracts smartcontracts requested a review from a team as a code owner December 4, 2024 19:49
@smartcontracts smartcontracts requested a review from tynes December 4, 2024 19:49
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 25 lines in your changes missing coverage. Please review.

Project coverage is 42.76%. Comparing base (ec05937) to head (bb9f8e3).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...s/contracts-bedrock/scripts/checks/spacers/main.go 58.33% 24 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13232      +/-   ##
===========================================
- Coverage    44.21%   42.76%   -1.46%     
===========================================
  Files          807      751      -56     
  Lines        72707    68009    -4698     
===========================================
- Hits         32151    29083    -3068     
+ Misses       37939    36481    -1458     
+ Partials      2617     2445     -172     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/contracts-bedrock/scripts/checks/spacers/main.go 66.29% <58.33%> (+66.29%) ⬆️

... and 64 files with indirect coverage changes

@mslipper mslipper added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit e253b19 Dec 4, 2024
44 checks passed
@mslipper mslipper deleted the sc/maint-spacers-rewrite branch December 4, 2024 23:28
sigma pushed a commit that referenced this pull request Dec 19, 2024
Updates the spacers check to use the new framework for contracts
checks written in Go. Adds tests for the functions that this
check uses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants