-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(op-deployer): Proxy
bootstrap command
#13213
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13213 +/- ##
===========================================
- Coverage 46.95% 42.26% -4.69%
===========================================
Files 923 756 -167
Lines 77648 68008 -9640
Branches 849 0 -849
===========================================
- Hits 36456 28745 -7711
+ Misses 38584 36885 -1699
+ Partials 2608 2378 -230
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d2e2a5b
to
a5897cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will leave to slipper to review for correctness but it generally looks good to me. I wonder if it's worth having an option to specify the implementation to use. May not be a good idea since we often need to upgradeAndCall so we can initialise in one step but thought I'd mention it.
I can also see this would often be best as something that we utilise in other scripts that would initialise things rather than just deploying this then having to build a superchain-ops task to init it etc. I like the general idea of having small little scripts like this that can then be easily combined though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the code review items. LGTM now.
* feat(op-deployer): `Proxy` bootstrap command * code review updates * linter --------- Co-authored-by: Matthew Slipper <[email protected]>
Overview
Adds a new bootstrap command to
op-deployer
that deploys an implementation-less 1967 Proxy. This is useful to have for one-off proxy deployments, such as when making a newFaultDisputeGame
and replacing theDelayedWETH
proxy it references.