Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op-deployer): Proxy bootstrap command #13213

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Conversation

clabby
Copy link
Member

@clabby clabby commented Dec 4, 2024

Overview

Adds a new bootstrap command to op-deployer that deploys an implementation-less 1967 Proxy. This is useful to have for one-off proxy deployments, such as when making a new FaultDisputeGame and replacing the DelayedWETH proxy it references.

@clabby clabby self-assigned this Dec 4, 2024
@clabby clabby requested review from a team as code owners December 4, 2024 02:48
@clabby clabby requested review from mbaxter, mslipper and ajsutton and removed request for mbaxter December 4, 2024 02:48
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 1.66667% with 118 lines in your changes missing coverage. Please review.

Project coverage is 42.26%. Comparing base (53b3af7) to head (ffc20a6).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/bootstrap/proxy.go 0.00% 116 Missing ⚠️
op-deployer/pkg/deployer/opcm/proxy.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13213      +/-   ##
===========================================
- Coverage    46.95%   42.26%   -4.69%     
===========================================
  Files          923      756     -167     
  Lines        77648    68008    -9640     
  Branches       849        0     -849     
===========================================
- Hits         36456    28745    -7711     
+ Misses       38584    36885    -1699     
+ Partials      2608     2378     -230     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/bootstrap/flags.go 0.00% <ø> (ø)
op-deployer/pkg/deployer/opcm/proxy.go 50.00% <50.00%> (ø)
op-deployer/pkg/deployer/bootstrap/proxy.go 0.00% <0.00%> (ø)

... and 176 files with indirect coverage changes

@clabby clabby force-pushed the cl/bootstrap-proxy branch from d2e2a5b to a5897cb Compare December 4, 2024 02:55
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave to slipper to review for correctness but it generally looks good to me. I wonder if it's worth having an option to specify the implementation to use. May not be a good idea since we often need to upgradeAndCall so we can initialise in one step but thought I'd mention it.

I can also see this would often be best as something that we utilise in other scripts that would initialise things rather than just deploying this then having to build a superchain-ops task to init it etc. I like the general idea of having small little scripts like this that can then be easily combined though.

@mslipper mslipper enabled auto-merge December 6, 2024 03:30
Copy link
Collaborator

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the code review items. LGTM now.

@mslipper mslipper added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit f17da35 Dec 6, 2024
43 checks passed
@mslipper mslipper deleted the cl/bootstrap-proxy branch December 6, 2024 03:45
sigma pushed a commit that referenced this pull request Dec 19, 2024
* feat(op-deployer): `Proxy` bootstrap command

* code review updates

* linter

---------

Co-authored-by: Matthew Slipper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants