Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: clean src imports #13056

Merged
merged 1 commit into from
Nov 25, 2024
Merged

maint: clean src imports #13056

merged 1 commit into from
Nov 25, 2024

Conversation

smartcontracts
Copy link
Contributor

Cleans up import statments in all contracts within the src/ directory. We should probably add a semgrep rule or a check that confirms that everything looks good. I'll leave that part for another commit.

@smartcontracts smartcontracts requested a review from a team as a code owner November 24, 2024 19:38
@smartcontracts smartcontracts force-pushed the sc/clean-imports branch 2 times, most recently from 37d11ea to 49d78ff Compare November 24, 2024 21:54
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (ea7f56c) to head (7319933).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13056      +/-   ##
===========================================
- Coverage    68.78%   66.77%   -2.02%     
===========================================
  Files           56       56              
  Lines         4665     4665              
===========================================
- Hits          3209     3115      -94     
- Misses        1274     1378     +104     
+ Partials       182      172      -10     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.72% <ø> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@smartcontracts smartcontracts marked this pull request as draft November 24, 2024 22:18
@smartcontracts
Copy link
Contributor Author

Going to wait until after the isthmus PR is in

@smartcontracts smartcontracts force-pushed the sc/clean-imports branch 2 times, most recently from eb2efdf to e494cd6 Compare November 25, 2024 01:34
@AmadiMichael
Copy link
Member

import { Attestation } from "../Common.sol";

This should also be

import { Attestation } from "src/vendor/eas/Common.sol";

Cleans up import statments in all contracts within the src/
directory. We should probably add a semgrep rule or a check that
confirms that everything looks good. I'll leave that part for
another commit.
@smartcontracts smartcontracts marked this pull request as ready for review November 25, 2024 22:21
@smartcontracts smartcontracts added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 2b589df Nov 25, 2024
44 checks passed
@smartcontracts smartcontracts deleted the sc/clean-imports branch November 25, 2024 22:29
@smartcontracts smartcontracts mentioned this pull request Nov 25, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants