Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-batcher: increase the transaction throttling limit to allow >99% of transactions #13047

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

roberto-bayardo
Copy link
Collaborator

Description

Analysis on base revealed that 99% of all transactions require less than 5000 DA bytes, including bundler transactions. This PR increases the default DA size of transactions that get throttled when DA is backlogged to this value.

@roberto-bayardo roberto-bayardo requested review from a team as code owners November 22, 2024 23:00
@roberto-bayardo roberto-bayardo changed the title increase the transaction throttling limit to allow >99% of transactions op-batcher: increase the transaction throttling limit to allow >99% of transactions Nov 22, 2024
@sebastianst sebastianst enabled auto-merge December 2, 2024 16:10
@roberto-bayardo roberto-bayardo added the A-op-batcher Area: op-batcher label Dec 2, 2024
@tynes
Copy link
Contributor

tynes commented Dec 3, 2024

/ci approve 1bc569e

@mslipper
Copy link
Collaborator

mslipper commented Dec 6, 2024

Merged in upstream to get the tests to pass.

@sebastianst sebastianst added this pull request to the merge queue Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.31%. Comparing base (53b3af7) to head (ce6271c).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13047      +/-   ##
===========================================
- Coverage    46.95%   42.31%   -4.64%     
===========================================
  Files          923      754     -169     
  Lines        77648    67888    -9760     
  Branches       849        0     -849     
===========================================
- Hits         36456    28725    -7731     
+ Misses       38584    36784    -1800     
+ Partials      2608     2379     -229     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-batcher/flags/flags.go 63.33% <ø> (ø)

... and 177 files with indirect coverage changes

Merged via the queue into develop with commit d6fa448 Dec 6, 2024
43 checks passed
@sebastianst sebastianst deleted the roberto/change-throttle-tx-default branch December 6, 2024 03:03
sigma pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-batcher Area: op-batcher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants