-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batcher: fix state inconsistency #12981
Merged
Merged
+26
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
commented
Nov 20, 2024
This was referenced Nov 20, 2024
2 tasks
We can use the channelManager's state to infer lastStoredBlock. And lastL1Tip is actually unused.
geoknee
force-pushed
the
gk/new-batcher-fix
branch
from
November 27, 2024 20:51
d8b1a59
to
d2a77a4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12981 +/- ##
===========================================
- Coverage 44.55% 42.85% -1.70%
===========================================
Files 799 743 -56
Lines 71845 67184 -4661
===========================================
- Hits 32009 28792 -3217
+ Misses 37230 35968 -1262
+ Partials 2606 2424 -182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axelKingsley
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new batcher got into a bad state when rolled out to devnet.
This PR removes some redundant state which was not being cleared, which should fix the problem.