feat: Isthmus Contracts #12746

maurelian · 2024-10-30T17:28:35Z

Description

Moves network specific values into L1Block.sol.

Fixes: #12297, #12349, #12298, #12299, #12300, #12301, #12303, #12304, #12305, #12655

Replaces #12057 with a squashed commit for a clean history.

packages/contracts-bedrock/snapshots/storageLayout/L1CrossDomainMessenger.json

packages/contracts-bedrock/snapshots/storageLayout/L1ERC721Bridge.json

packages/contracts-bedrock/snapshots/storageLayout/L1OptimismMintableERC20Factory.json

packages/contracts-bedrock/snapshots/storageLayout/L2OptimismMintableERC20Factory.json

packages/contracts-bedrock/snapshots/storageLayout/L1OptimismMintableERC20Factory.json

packages/contracts-bedrock/snapshots/storageLayout/L1StandardBridge.json

packages/contracts-bedrock/snapshots/storageLayout/L1CrossDomainMessenger.json

packages/contracts-bedrock/snapshots/storageLayout/L2CrossDomainMessenger.json

packages/contracts-bedrock/snapshots/storageLayout/L2ERC721Bridge.json

packages/contracts-bedrock/snapshots/storageLayout/L2ProxyAdmin.json

packages/contracts-bedrock/snapshots/storageLayout/L2StandardBridge.json

packages/contracts-bedrock/snapshots/storageLayout/L2StandardBridgeInterop.json

packages/contracts-bedrock/src/L2/interfaces/IL1BlockInterop.sol

packages/contracts-bedrock/src/libraries/StaticConfig.sol

packages/contracts-bedrock/src/universal/CrossDomainMessenger.sol

This reverts commit dad1087.

* Revert "feat: Isthmus Contracts (#12746)" This reverts commit dad1087. * temporarily reduce heavy fuzz runs

@notice

* feat: Isthmus Contracts work squashed remove unused import fix: IOptimismMintableERC721 interface feat: move semver out of abstract OptimismMintableERC20Factory Also add spacer after _initialized/ing fix: Initializer check in DeployOPChain fix: CrossDomainOwnable3 test feat: update semver-lock feat: Add systemConfigAdmin to deploy-config fix: IL1BlockInterop iface fix: update devnetL1-template fix: casing on systemConfigFeeAdmin feat: update ConfigType names feat: rename setHolocene to setL1BlockValuesIsthmus feat: refine setL1BLockValuesIsthmus to read fee vault config directly from getters. fix: read remoteChainId from ERC721 Factory, not Bridge feat: Update test_setL1BlockValuesIsthmus_isDepositor_succeeds to compare with cfg feat: use setIsthmus() * debug: Add fee admin to intent * fix: fee vault immutable checks no longer necessary * fix: TestConfigDataMarshalUnmarshal * fix: immutable check for L2ProxyAdmin owner * fix: SystemConfigFeeAdmin naming in opchain.go * feat: op-deployer - get SystemConfigFeeAdmin from intent.Roles * remove dead comments * feat: resolve feeAdmin setting todo coment * feat: move unsafeBLockSigner into SystemConfig.Roles struct * feat: move batcherHash into SystemConfig.Roles struct * fix: Add missing feeAdmin setter in DeployOpChain test * fix: SystemConfig.init in specs * feat: resolve todo * feat: resolve some todos * feat: Natspec in StaticConfig * feat: resolve some todos * fix: test_getConfigRoundtripGasPayingToken_succeeds with normalizeSmallString * pre-pr * test: Implement roll and reset prevBought gas in SystemConfig Test's cleanStorageAndInit() * feat: Add natspec on SystemConfig.Roles * feat: Fix all incomplete @notice natspec comments * feat: systemConfigFeeAdmin name in opcm * rebuild snapshots * Add ArtifactsFromURL utility * add configurability to createEnv * clean up env.go * fix apply test * fix: TestInteropDeployment * fix: TestApplyExistingOPCM * fix: unchecked return on checkImmutable * fix: goimports env.go * fix: Add devkey for SystemConfigFeeAdmin * fix: TestInteropDeployment * fix: TestInteropDevRecipe * feat: use base CDM interface in L1Block * feat: configure L1 Block config values in L2Genesis * feat: document Isthmus upgrade transactions on `setIsthmus()` * semver fixes * feat: L2 Genesis with cheated config in L1Block * ok: how'd those warnings get in there in the first place? * chore: update semver-lock * works * allocs build, cfg calls commented out cuz they fail * fix: read DeployConfig before it gets deleted * fix: test_allocs_size * fix: restore l1 deps * fix: test_getConfigRoundtripGasPayingToken_succeeds disallow eth address * fix: update test_proveWithdrawalTransaction_benchmark Unclear why this cost changed? * feat: Add Isthmus to Config.sol * feat: hoist L1Block population above allocs writes * chore: delete debug logs * WIP: update SystemConfig bindings and go usage * fix: go linting * feat: deposit setGasPayingToken as first call in SystemConfig.init * semver lock * TODO in L2Genesis * chore: semver * fix: Remove outdated comments * feat: extract logic into _setNetworkConfig() * test: Add total gas usage test * remove dead comment * ci: reduce heavy fuzz runs temporarily --------- Co-authored-by: Matthew Slipper <[email protected]>

…um-optimism#12870) * Revert "feat: Isthmus Contracts (ethereum-optimism#12746)" This reverts commit dad1087. * temporarily reduce heavy fuzz runs