op-service: support storage key RPC response with <32 bytes #12576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyer9
force-pushed
the
meyer9/fix/account-proof-storage-key-type
branch
from
1703d7c to
ba32a7c
Compare
ajsutton
approved these changes
Oct 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 23, 2024
93f5d41
47 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports truncated storage keys (
0x123instead of0x0000...000123) which can be returned by geth or reth if a truncated key is passed in. reth always returns truncated keys currently which is incorrect behavior and will be fixed. Even when fixed, truncated keys will still be returned if truncated keys are passed, so this type is incorrect regardless.Geth uses a string here, but hexutils.Big will ensure the key is always <= 32 bytes.
Tests
Added a test to ensure unmarshalling truncated storage key works.
Additional context
Discord conversation with reth contributors: https://discord.com/channels/1244729134312198194/1244729507588608040/1298354265294770196