Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: Run validations over L2 genesis #12560

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

mslipper
Copy link
Collaborator

Asserts that the L2 genesis is valid using our pre-existing checks prior to running the script.

Asserts that the L2 genesis is valid using our pre-existing checks prior to running the script.
Copy link
Contributor

semgrep-app bot commented Oct 22, 2024

Semgrep found 1 sol-style-require-reason finding:

  • packages/contracts-bedrock/src/L2/SuperchainWETH.sol

require() must include a reason string

Ignore this finding from sol-style-require-reason.

Semgrep found 5 sol-style-input-arg-fmt findings:

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

@mds1 mds1 added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit 3b83710 Oct 22, 2024
48 checks passed
@mds1 mds1 deleted the feat/l2-genesis-validation branch October 22, 2024 16:38
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
* op-deployer: Run validations over L2 genesis

Asserts that the L2 genesis is valid using our pre-existing checks prior to running the script.

* add negative test

* fix broken test

* clarify test name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants