feat: op-program --network flag accepts number as chainid #12503
+65
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
reviewed
Oct 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 20, 2024
a0aa656
47 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…ptimism#12503) * feat: op-program --network flag accepts number as chainid * put common parse code into rollup.Config struct * address comments --------- Co-authored-by: Qi Zhou <[email protected]>
ajsutton
pushed a commit
that referenced
this pull request
Dec 1, 2024
* feat: op-program --network flag accepts number as chainid * put common parse code into rollup.Config struct * address comments --------- Co-authored-by: Qi Zhou <[email protected]>
ajsutton
pushed a commit
that referenced
this pull request
Dec 8, 2024
* feat: op-program --network flag accepts number as chainid * put common parse code into rollup.Config struct * address comments --------- Co-authored-by: Qi Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will allow the
op-programto use the embedded custom rollup config, where the chainid of the custom rollup is passed via--networkflag. This way, we can now verifyop-programin the independent process mode.Tests
Run devnet locally, then pass
make verify-devnetunder theop-programfolder.Additional context
Metadata