Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannon: use constant instead of magic value for solidity part #12484

Merged
merged 2 commits into from
Oct 17, 2024
Merged

cannon: use constant instead of magic value for solidity part #12484

merged 2 commits into from
Oct 17, 2024

Conversation

zhiqiangxu
Copy link
Contributor

This is a follow-up PR for this one, which does the same to the solidity part.

@zhiqiangxu zhiqiangxu force-pushed the calling_convention_solidity branch from 6612bea to 5bb45c5 Compare October 16, 2024 14:38
@Inphi Inphi mentioned this pull request Oct 16, 2024
Closed
Inphi
Inphi reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L:ooks good. Could you also bump the beta semver in MIPS.sol and MIPS2.sol? You'll have to also generate the semver-lock file using just semver-lock.

@zhiqiangxu
Copy link
Contributor Author

L:ooks good. Could you also bump the beta semver in MIPS.sol and MIPS2.sol? You'll have to also generate the semver-lock file using just semver-lock.

Done.

@zhiqiangxu zhiqiangxu force-pushed the calling_convention_solidity branch 2 times, most recently from 676d696 to b62c6c8 Compare October 17, 2024 02:14
@Inphi
Copy link
Contributor

Inphi commented Oct 17, 2024

@zhiqiangxu Thanks. There's a merge conflict in the semver. Could you take a look?

@zhiqiangxu zhiqiangxu force-pushed the calling_convention_solidity branch from b62c6c8 to 928d968 Compare October 17, 2024 14:49
@zhiqiangxu
Copy link
Contributor Author

@zhiqiangxu Thanks. There's a merge conflict in the semver. Could you take a look?

Done.

@Inphi Inphi added this pull request to the merge queue Oct 17, 2024
Merged via the queue into ethereum-optimism:develop with commit 56330c0 Oct 17, 2024
51 checks passed
@blockchaindevsh blockchaindevsh mentioned this pull request Oct 19, 2024
Closed
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@zhiqiangxu @samlaf
cannon: use constant instead of magic value for solidity part (ethere…
d6a6389 
…um-optimism#12484)

* cannon: use constant instead of magic value for solidity part

* update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inphi Inphi Inphi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiqiangxu @Inphi