Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move checkOutput from DeployOPChainOutput to DeployOPChain script #12469

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

maurelian
Copy link
Contributor

Description

Moves checkOutput() and assertValidDeploy() and all other similar assertX() functions from DeployOPChainOutput to DeployOPChain, as the I/O contracts should be kept as simple as possible.

The amount of code which is moved makes the diff confusing to read. The actual changes are limited to:

  1. moving the code as described above
  2. Adding a DeployOutput _doo argument to each assert function
  3. Prepending calls to get contract addresses with _doo (ie. opChainProxyAdmin() becomes _doo.opChainProxyAdmin().

@maurelian maurelian requested a review from mds1 October 15, 2024 18:55
Copy link
Contributor

semgrep-app bot commented Oct 16, 2024

Semgrep found 6 sol-style-input-arg-fmt findings:

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

Semgrep found 1 golang_fmt_errorf_no_params finding:

  • op-supervisor/supervisor/backend/db/db_test.go

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

Semgrep found 1 math-random-used finding:

  • op-supervisor/supervisor/backend/source/head_monitor_test.go

Do not use math/rand. Use crypto/rand instead.

Ignore this finding from math-random-used.

Semgrep found 1 marshal-json-pointer-receiver finding:

  • op-supervisor/supervisor/backend/db/heads/types.go

MarshalJSON with a pointer receiver has surprising results: golang/go#22967

Ignore this finding from marshal-json-pointer-receiver.

Semgrep found 1 err-nil-check finding:

superfluous nil err check before return

Ignore this finding from err-nil-check.

@blmalone blmalone self-requested a review October 16, 2024 17:34
Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maurelian maurelian added this pull request to the merge queue Oct 16, 2024
Merged via the queue into develop with commit dfdc28b Oct 16, 2024
49 checks passed
@maurelian maurelian deleted the move-checkOutput branch October 16, 2024 17:51
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
…pt (ethereum-optimism#12469)

* feat: Move checkOutput from DeployOPChainOutput to DeployOPChain script

* fix: Fix compiler warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants