Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MT Cannon: add mips mul/div tests #12459

Merged
merged 1 commit into from
Oct 22, 2024
Merged

MT Cannon: add mips mul/div tests #12459

merged 1 commit into from
Oct 22, 2024

Conversation

GrapeBaBa
Copy link
Contributor

Description

This PR add mips mul/div tests

Tests

Additional context

Metadata

@GrapeBaBa GrapeBaBa requested review from a team as code owners October 15, 2024 13:27
@GrapeBaBa GrapeBaBa requested a review from refcell October 15, 2024 13:27
@GrapeBaBa
Copy link
Contributor Author

@Inphi @mbaxter can you help re trigger the CI, lint and test already passed in my local env

@Inphi Inphi self-assigned this Oct 17, 2024
@Inphi
Copy link
Contributor

Inphi commented Oct 17, 2024

@Inphi @mbaxter can you help re trigger the CI, lint and test already passed in my local env

@GrapeBaBa Done. Could you rebase on the latest develop to fix the flaky tests.

@GrapeBaBa
Copy link
Contributor Author

@Inphi Aleady rebased but still got lint error, I tried make lint-go locally and no errors.

Inphi
Inphi approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Inphi Inphi added this pull request to the merge queue Oct 22, 2024
Merged via the queue into ethereum-optimism:develop with commit b93daad Oct 22, 2024
51 checks passed
@Inphi Inphi mentioned this pull request Oct 23, 2024
Merged
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@GrapeBaBa @samlaf
feat:add cannon mips mul/div tests (ethereum-optimism#12459)
6ffe618 
Signed-off-by: Chen Kai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inphi Inphi Inphi approved these changes

@refcell refcell Awaiting requested review from refcell refcell is a code owner automatically assigned from ethereum-optimism/proofs

Assignees

@Inphi Inphi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MTCannon: Create mul/div opcodes tests
2 participants
@GrapeBaBa @Inphi