fix(ct): deploy MIPS2 properly #12365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
approved these changes
Oct 8, 2024
smartcontracts
force-pushed
the
sc/ct-fix-mips2-deploy
branch
2 times, most recently
from
e3625c8 to
068752e
Compare
smartcontracts
force-pushed
the
sc/ct-fix-mips2-deploy
branch
from
068752e to
67e57ba
Compare
Adds a new configuration to DeployImplementations so that it knows which MIPS version to deploy.
smartcontracts
force-pushed
the
sc/ct-fix-mips2-deploy
branch
from
67e57ba to
506180f
Compare
clabby
approved these changes
Oct 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12365 +/- ##
===========================================
- Coverage 64.10% 63.91% -0.19%
===========================================
Files 52 52
Lines 4312 4312
===========================================
- Hits 2764 2756 -8
- Misses 1374 1383 +9
+ Partials 174 173 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Adds a new configuration to DeployImplementations so that it knows which MIPS version to deploy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new configuration to DeployImplementations so that it knows which MIPS version to deploy.