OPCM: DeployOPChain additional testing checks.

[blmalone]

Adding some additional checks PermissionedDisputeGame and AnchorStateRegistryProxy.

[blmalone]

• OPCM: DeployOPChain additional testing checks. #12355 👈
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blmalone and the rest of your teammates on Graphite

[semgrep-app]

Semgrep found 13 sol-style-malformed-require findings:

• packages/contracts-bedrock/src/cannon/PreimageOracle.sol
  • L100 - Triage
• packages/contracts-bedrock/scripts/periphery/deploy/DeployPeriphery.s.sol
  • L280 - Triage
• packages/contracts-bedrock/scripts/libraries/DeployUtils.sol
  • L207 - Triage
  • L243 - Triage
  • L256 - Triage
• packages/contracts-bedrock/scripts/deploy/DeployOwnership.s.sol
  • L377 - Triage
• packages/contracts-bedrock/scripts/deploy/DeployConfig.s.sol
  • L100 - Triage
• packages/contracts-bedrock/scripts/deploy/Deploy.s.sol
  • L239 - Triage
  • L240 - Triage
• packages/contracts-bedrock/scripts/deploy/ChainAssertions.sol
  • L587 - Triage
• packages/contracts-bedrock/scripts/autogen/SemverLock.s.sol
  • L51 - Triage
• packages/contracts-bedrock/scripts/DeploySuperchain.s.sol
  • L195 - Triage
  • L196 - Triage

"challenge period too large" Malformed require statement style.

_{Ignore this finding from sol-style-malformed-require.}

[mds1]

LGTM, just one missing check to add?

[semgrep-app]

Semgrep found 4 sol-style-return-arg-fmt findings:

• packages/contracts-bedrock/scripts/interfaces/IGnosisSafe.sol
  • L79 - Triage
  • L87 - Triage
  • L95 - Triage
  • L103 - Triage

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

Semgrep found 2 sol-style-malformed-revert findings:

• packages/contracts-bedrock/scripts/deploy/DeployConfig.s.sol
  • L205 - Triage
• packages/contracts-bedrock/scripts/deploy/Deploy.s.sol
  • L1292 - Triage

Malformed revert statement style.

_{Ignore this finding from sol-style-malformed-revert.}

Semgrep found 22 sol-style-input-arg-fmt findings:

• packages/contracts-bedrock/scripts/interfaces/IGnosisSafe.sol
  • L34 - Triage
  • L35 - Triage
  • L38-39 - Triage
  • L46 - Triage
  • L47 - Triage
  • L49 - Triage
  • L50-51 - Triage
  • L65-66 - Triage
  • L80-81 - Triage
  • L88-89 - Triage
  • 12 more - Triage

Inputs to functions must be prepended with an underscore (_)

_{Ignore this finding from sol-style-input-arg-fmt.}