Add binary deserialization to asterisc's state converter trace function #12238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
reviewed
Oct 2, 2024
mininny
force-pushed
the
feature/mininny/asterisc-binary-serialization
branch
3 times, most recently
from
a9e250e to
d5e9984
Compare
|
Currently includes diff for #12265, but will be rebase this PR to develop once it's merged. |
mininny
force-pushed
the
feature/mininny/asterisc-binary-serialization
branch
from
d5e9984 to
9a92763
Compare
ajsutton
reviewed
Oct 3, 2024
mininny
force-pushed
the
feature/mininny/asterisc-binary-serialization
branch
from
55d7533 to
a55aea4
Compare
mininny
force-pushed
the
feature/mininny/asterisc-binary-serialization
branch
from
a55aea4 to
9d908cc
Compare
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 4, 2024
b02dba0
55 checks passed
protolambda
pushed a commit
that referenced
this pull request
Oct 7, 2024
…on (#12238) * Move serialize from cannon to op-service * Add binary deserialization to asterisc's state converter trace function * Use Asterisc's witness cmd to generate state data * Fix op-challenger tests * remove unnecessary logic from state_converter, and only test witness subcommand
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…on (ethereum-optimism#12238) * Move serialize from cannon to op-service * Add binary deserialization to asterisc's state converter trace function * Use Asterisc's witness cmd to generate state data * Fix op-challenger tests * remove unnecessary logic from state_converter, and only test witness subcommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for binary serialization of VMState for Asterisc, while preserving compatibility with JSON snapshots. We infer the type of the snapshot by looking at the file type, and dynamically choose whether to use binary representation of json representation.
This is dependency PR of Asterisc PR here: ethereum-optimism/asterisc#82
This is used in Asterisc's op-e2e tests, where a prestate file is converted into VMState instance in op-challenger trace provider